Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump browserify-sign to v 4.2.2 #7633

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

tommasini
Copy link
Contributor

Description

Minor version used on the app was 4.0.0

New version 4.2.2

No major upgrades
https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md

Related issues

Fixes: #

Manual testing steps

Screenshots/Recordings

Sanity test:
https://recordit.co/yLlLmu5s2f

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. Run Smoke E2E labels Oct 27, 2023
@github-actions
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/205e6a35-5dfe-4f3b-b9ea-3fc4e35b905e
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@github-actions
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/282d3d22-25fd-4c64-a29c-1a6b119dfae2
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/react-native-background-timer 2.0.0 None +0 3.5 kB types
@metamask/approval-controller 3.4.0 None +1 121 kB metamaskbot
@types/enzyme 3.10.12 None +0 35 kB types
@metamask/design-tokens 1.12.0 None +0 113 kB gudahtt
@babel/preset-env 7.22.6 None +0 143 kB nicolo-ribaudo
prop-types 15.7.2 environment +0 97.7 kB ljharb
base-64 1.0.0 None +0 10.9 kB mathias
@sentry/integrations 6.3.1 network +0 2.54 MB sentry-bot
through2 3.0.1 None +0 17.4 kB rvagg
humanize-duration 3.27.3 None +0 65.9 kB evanhahn

@socket-security
Copy link

socket-security bot commented Oct 27, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: react-native-branch@5.6.2, browserify-sign@4.2.2, Base64@0.2.1, fbjs@3.0.0, @sentry/integrations@6.3.1, @storybook/api@6.5.16, shaka-player@2.5.23

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d894f7e) 34.98% compared to head (75218a3) 34.99%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7633   +/-   ##
=======================================
  Coverage   34.98%   34.99%           
=======================================
  Files        1030     1030           
  Lines       27382    27385    +3     
  Branches     2253     2253           
=======================================
+ Hits         9580     9583    +3     
  Misses      17292    17292           
  Partials      510      510           
Files Coverage Δ
app/components/Views/ChoosePassword/index.js 3.77% <ø> (ø)
app/components/Views/Login/index.js 9.09% <ø> (ø)
app/components/Views/Onboarding/index.js 4.27% <ø> (ø)
app/components/Views/ResetPassword/index.js 6.15% <ø> (ø)
app/constants/test-ids.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tommasini
Copy link
Contributor Author

More context on this thread

@sethkfman
Copy link
Contributor

@SocketSecurity ignore-all

@sethkfman sethkfman merged commit 35c62b8 into main Oct 27, 2023
37 checks passed
@sethkfman sethkfman deleted the fix/bump-browserify-sign branch October 27, 2023 15:04
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 27, 2023
@metamaskbot metamaskbot added the release-7.11.0 Issue or pull request that will be included in release 7.11.0 label Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.11.0 Issue or pull request that will be included in release 7.11.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants