-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update selectors for contract approval modal #7639
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7639 +/- ##
=======================================
Coverage 34.97% 34.98%
=======================================
Files 1030 1030
Lines 27379 27376 -3
Branches 2253 2253
=======================================
Hits 9577 9577
+ Misses 17292 17289 -3
Partials 510 510 ☔ View full report in Codecov by Sentry. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ca220a77-a489-48dc-a18a-de8b608a7bda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good, left a couple of comments.
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ ✅ ✅ ✅
Description
Update selectors for contract approve modal.
Renamed files and classes to relate more to contract approval.
Related issues
Relates: #7560
Manual testing steps
Screenshots/Recordings
Private Zenhub Image
Before
After
Restructuring of selectors for ApprovalModal, now called ContractApprovalModal.
Pre-merge author checklist
Pre-merge reviewer checklist