Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update selectors for contract approval modal #7639

Merged
merged 7 commits into from
Nov 1, 2023

Conversation

chrisleewilcox
Copy link
Contributor

@chrisleewilcox chrisleewilcox commented Oct 29, 2023

Description

Update selectors for contract approve modal.
Renamed files and classes to relate more to contract approval.

Related issues

Relates: #7560

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

image

Private Zenhub Image

Before

After

Restructuring of selectors for ApprovalModal, now called ContractApprovalModal.

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@chrisleewilcox chrisleewilcox self-assigned this Oct 29, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chrisleewilcox chrisleewilcox added team-mobile-client E2E needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Oct 29, 2023
@chrisleewilcox chrisleewilcox changed the title chore: Update selectors for contract approve modal chore: Update selectors for contract approval modal Oct 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3022144) 34.97% compared to head (243e2dd) 34.98%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7639   +/-   ##
=======================================
  Coverage   34.97%   34.98%           
=======================================
  Files        1030     1030           
  Lines       27379    27376    -3     
  Branches     2253     2253           
=======================================
  Hits         9577     9577           
+ Misses      17292    17289    -3     
  Partials      510      510           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisleewilcox chrisleewilcox marked this pull request as ready for review October 29, 2023 20:45
@chrisleewilcox chrisleewilcox requested a review from a team as a code owner October 29, 2023 20:45
@github-actions
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ca220a77-a489-48dc-a18a-de8b608a7bda
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good, left a couple of comments.

e2e/specs/confirmations/approve-custom-erc20.spec.js Outdated Show resolved Hide resolved
e2e/specs/confirmations/approve-default-erc20.spec.js Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ ✅ ✅ ✅

@chrisleewilcox chrisleewilcox merged commit 8894be4 into main Nov 1, 2023
25 checks passed
@chrisleewilcox chrisleewilcox deleted the detox-restructure-modal-selectors branch November 1, 2023 15:39
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
@metamaskbot metamaskbot added the release-7.11.0 Issue or pull request that will be included in release 7.11.0 label Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E2E release-7.11.0 Issue or pull request that will be included in release 7.11.0 team-mobile-platform tech-debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants