-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: action view btn not able translate #7642
Conversation
context will not able to pass in to defaultProps, hence default translation should apply into the component itself
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7642 +/- ##
=======================================
Coverage 34.98% 34.98%
=======================================
Files 1030 1030
Lines 27376 27378 +2
Branches 2253 2253
=======================================
+ Hits 9577 9579 +2
Misses 17289 17289
Partials 510 510
☔ View full report in Codecov by Sentry. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6ae8d18c-5eeb-4c10-8386-6280d1a99790 |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
18in context will not able to pass in to defaultProps of a component, hence default translation should apply into the component itself instead
Related issues
Fixes: #
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist