Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bluetooth library support #7644

Merged
merged 10 commits into from
Nov 10, 2023
Merged

Conversation

stanleyyconsensys
Copy link
Contributor

@stanleyyconsensys stanleyyconsensys commented Oct 30, 2023

Description

Add bluetooth library support

  • enable bluetooth permission in native
  • add bluetooth react native package
  • add hook to support permission determindation

Related issues

Fixes: #

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@stanleyyconsensys stanleyyconsensys added team-accounts Ledger Ledger hardware wallet related issue or development labels Oct 30, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link

socket-security bot commented Oct 30, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
react-native-permissions 3.10.1 None +0 518 kB zoontek

@socket-security
Copy link

socket-security bot commented Oct 30, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@dawnseeker8 dawnseeker8 marked this pull request as ready for review November 1, 2023 03:58
@dawnseeker8 dawnseeker8 requested a review from a team as a code owner November 1, 2023 03:58
Copy link
Contributor

github-actions bot commented Nov 1, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cdac7b24-38d0-4b75-8914-9f5c85d7c20f
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

igorms-cons
igorms-cons previously approved these changes Nov 2, 2023
@montelaidev
Copy link

Whats the best way to test this?

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments

ios/MetaMask/MetaMask-QA-Info.plist Outdated Show resolved Hide resolved
ios/Podfile Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
@dawnseeker8
Copy link
Contributor

hi @montelaidev current this PR is part of ledger feature, and the fully functional codes will be in this branch https://github.com/MetaMask/metamask-mobile/tree/feat/ledger-enable. so currently there is not way to test it.

@codecov-commenter
Copy link

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (351778e) 34.97% compared to head (b2a2dc6) 34.93%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7644      +/-   ##
==========================================
- Coverage   34.97%   34.93%   -0.05%     
==========================================
  Files        1034     1035       +1     
  Lines       27529    27566      +37     
  Branches     2298     2307       +9     
==========================================
  Hits         9629     9629              
- Misses      17387    17424      +37     
  Partials      513      513              
Files Coverage Δ
app/components/hooks/useBluetoothPermissions.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dawnseeker8 dawnseeker8 merged commit 7c1b78e into main Nov 10, 2023
26 checks passed
@dawnseeker8 dawnseeker8 deleted the feat/add-bluetooth-permission branch November 10, 2023 00:24
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ledger Ledger hardware wallet related issue or development release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants