fix: revert nonce logic in transaction controller

[matthewwalsh0]

Description

The TransactionController was recently upgraded to a version using the NonceTracker package.

This looks at local transactions for the same address and chain to determine the best nonce value.

Since the mobile client monitors incoming token transfers, this was resulting in incorrect nonce values due to the associated transactions having the from address of the account sending the balance, rather than the address of the account creating the transaction.

The temporary fix is to revert the nonce logic in the TransactionController by removing usage of the NonceTracker.

Related issues

Fixes: #7646

Manual testing steps

1. Add account X to the wallet.
2. Add a token balance to account X.
3. Send an approve transaction from account X for the same token to account Y.
4. Send a transferFrom transaction from account Y (ideally from a different wallet), that transfers the token from account X.
5. Wait for the incoming transaction to be detected, this is not visible in the activity list but polled every ~30 seconds.
6. Try and send any transaction from account X and confirm the nonce is not the transfer nonce from account Y + 1.

Screenshots/Recordings

Before

After

See comments.

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fcc151f8-ef03-46f8-9752-1bf17ba962fd
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[seaona]

QA passed. Confirming performing a transferFrom for ERC20 and ERC721 with Account 1 (from Account 2) and then a subsequent transaction with Account 2, has the correct nonce set for both cases

erc20transferfrom.mp4

erc721transferfrom.mp4