-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: update PPOM Validator to address blockaid performance issues #7662
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1692ed83-507a-418c-a060-a4e172df0706 |
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7662 +/- ##
=======================================
Coverage 35.00% 35.00%
=======================================
Files 1034 1034
Lines 27550 27550
Branches 2284 2284
=======================================
+ Hits 9643 9644 +1
+ Misses 17396 17395 -1
Partials 511 511
☔ View full report in Codecov by Sentry. |
…mobile into ppom_validator_update
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
@SocketSecurity ignore @metamask/ppom-validator@0.10.0 |
Kudos, SonarCloud Quality Gate passed! |
Description
Update pom-validator.
Latest update of PPOM has performance improvements which are need for mobile app.
Related issues
Fixes: MetaMask/MetaMask-planning#1555
Manual testing steps
Screenshots/Recordings
NA
Before
NA
After
NA
Pre-merge author checklist
Pre-merge reviewer checklist