Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update PPOM Validator to address blockaid performance issues #7662

Merged
merged 5 commits into from
Nov 7, 2023

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Nov 1, 2023

Description

Update pom-validator.
Latest update of PPOM has performance improvements which are need for mobile app.

Related issues

Fixes: MetaMask/MetaMask-planning#1555

Manual testing steps

  1. Open the app
  2. Go to test DAPP
  3. Send malicious transaction
  4. It should show alert

Screenshots/Recordings

NA

Before

NA

After

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Nov 1, 2023
@jpuri jpuri requested a review from a team as a code owner November 1, 2023 16:16
Copy link
Contributor

github-actions bot commented Nov 1, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri changed the title Update PPOM Validator Fix: update PPOM Validator to address blockaid performance issues Nov 1, 2023
Copy link
Contributor

github-actions bot commented Nov 1, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1692ed83-507a-418c-a060-a4e172df0706
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

socket-security bot commented Nov 1, 2023

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/ppom-validator 0.7.0...0.10.0 None +0/-0 135 kB

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7524a07) 35.00% compared to head (92f7488) 35.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7662   +/-   ##
=======================================
  Coverage   35.00%   35.00%           
=======================================
  Files        1034     1034           
  Lines       27550    27550           
  Branches     2284     2284           
=======================================
+ Hits         9643     9644    +1     
+ Misses      17396    17395    -1     
  Partials      511      511           
Files Coverage Δ
app/core/Engine.ts 54.18% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bschorchit bschorchit added team-confirmations-secure-ux-PR PR from the confirmations team and removed team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Nov 1, 2023
blackdevelopa
blackdevelopa previously approved these changes Nov 2, 2023
@jpuri
Copy link
Contributor Author

jpuri commented Nov 3, 2023

Copy link

socket-security bot commented Nov 7, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @metamask/ppom-validator@0.10.0

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@jpuri
Copy link
Contributor Author

jpuri commented Nov 7, 2023

@SocketSecurity ignore @metamask/ppom-validator@0.10.0

Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@jpuri jpuri merged commit c9322e4 into main Nov 7, 2023
25 checks passed
@jpuri jpuri deleted the ppom_validator_update branch November 7, 2023 13:20
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 7, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants