-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Wallet not switching networks when add new network requested by a dapp #7667
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/04167bf4-be88-47eb-9973-1d0387750a72 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7667 +/- ##
=======================================
Coverage 34.95% 34.95%
=======================================
Files 1030 1030
Lines 27363 27363
Branches 2253 2253
=======================================
Hits 9564 9564
Misses 17289 17289
Partials 510 510
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
Kudos, SonarCloud Quality Gate passed! |
Description
The wallet was not switching networks after adding a new network added by a dapp.
It was a promise not resolved
Related issues
Fixes: #
Manual testing steps
Dapp where it is easy to reproduce: https://chris-react-dapp.vercel.app/
Screenshots/Recordings
Before
In the issue description: https://github.com/MetaMask/mobile-planning/issues/1346
After
https://recordit.co/lDMTEaaKq1
Pre-merge author checklist
Pre-merge reviewer checklist