Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wallet not switching networks when add new network requested by a dapp #7667

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Nov 2, 2023

Description

The wallet was not switching networks after adding a new network added by a dapp.

It was a promise not resolved

Related issues

Fixes: #

Manual testing steps

Dapp where it is easy to reproduce: https://chris-react-dapp.vercel.app/

  1. Connect to dapp via QR Code or deeplink
  2. Tap "Add Polygon chain"
  3. Accept adding the Polygon chain
  4. Accept the switch to Polygon
  5. The chain dropdown is not updated

Screenshots/Recordings

Before

In the issue description: https://github.com/MetaMask/mobile-planning/issues/1346

After

https://recordit.co/lDMTEaaKq1

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini requested a review from a team as a code owner November 2, 2023 00:08
Copy link
Contributor

github-actions bot commented Nov 2, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Nov 2, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/04167bf4-be88-47eb-9973-1d0387750a72
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@metamaskbot metamaskbot added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c312ee8) 34.95% compared to head (4417da5) 34.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7667   +/-   ##
=======================================
  Coverage   34.95%   34.95%           
=======================================
  Files        1030     1030           
  Lines       27363    27363           
  Branches     2253     2253           
=======================================
  Hits         9564     9564           
  Misses      17289    17289           
  Partials      510      510           
Files Coverage Δ
app/core/RPCMethods/wallet_addEthereumChain.js 80.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@frankvonhoven frankvonhoven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox added QA in Progress QA has started on the feature. and removed QA in Progress QA has started on the feature. labels Nov 2, 2023
@siosio34
Copy link

siosio34 commented Nov 2, 2023

LGTM

@tommasini tommasini added the No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. label Nov 2, 2023
Copy link

sonarcloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@tommasini
Copy link
Contributor Author

@tommasini tommasini merged commit ba06e74 into main Nov 2, 2023
25 checks passed
@tommasini tommasini deleted the fix/1346-dapp-switch-chain branch November 2, 2023 22:57
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 2, 2023
@metamaskbot metamaskbot added the release-7.11.0 Issue or pull request that will be included in release 7.11.0 label Nov 2, 2023
@gauthierpetetin gauthierpetetin added team-mobile-platform team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead labels Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.11.0 Issue or pull request that will be included in release 7.11.0 team-mobile-platform team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants