Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable permission-system-revoking-multiple-accounts detox test #7668

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

SamuelSalas
Copy link
Member

Description

Fix that disabled permission-system-revoking-multiple-account.spec.js detox test. At this moment is failing on main. The file has been relocated to the quarantine file. permission-system-revoke-single-account.spec.js has also been moved from the Regression test suite to the Smoke test suite.

Related issues

Fixes: #

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Nov 2, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2944bc37-afb8-4995-97d2-f885fcd18ab2
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc0314d) 34.95% compared to head (6978cc2) 34.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7668   +/-   ##
=======================================
  Coverage   34.95%   34.95%           
=======================================
  Files        1030     1030           
  Lines       27363    27363           
  Branches     2253     2253           
=======================================
  Hits         9564     9564           
  Misses      17289    17289           
  Partials      510      510           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cortisiko cortisiko merged commit 4f15547 into main Nov 2, 2023
31 checks passed
@cortisiko cortisiko deleted the fix/disable-revoking-multiple-accounts-test branch November 2, 2023 14:03
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
@metamaskbot metamaskbot added the release-7.11.0 Issue or pull request that will be included in release 7.11.0 label Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.11.0 Issue or pull request that will be included in release 7.11.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants