Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove init launch app #7678

Merged
merged 4 commits into from
Nov 3, 2023
Merged

Conversation

chrisleewilcox
Copy link
Contributor

@chrisleewilcox chrisleewilcox commented Nov 3, 2023

Description

Our automated tests are launching the app multiple times at the start of the tests. To improve performance and stability of tests the tests should only launch the app once at the beginning of tests.

Didn't remove init.js because there is an error that occurs when running tests without init.js.

Related issues

Fixes: #https://github.com/MetaMask/mobile-planning/issues/1348

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

App would launch twice at the start of tests.

After

App launches only once at the start of tests.

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@chrisleewilcox chrisleewilcox requested a review from a team as a code owner November 3, 2023 07:06
Copy link
Contributor

github-actions bot commented Nov 3, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chrisleewilcox chrisleewilcox self-assigned this Nov 3, 2023
@chrisleewilcox chrisleewilcox changed the title chore: remove init launch app fix: remove init launch app Nov 3, 2023
Copy link
Contributor

github-actions bot commented Nov 3, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fc6970c2-339f-4b95-a2ef-f8042abc3b83
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a803ec8) 34.86% compared to head (d3cc220) 34.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7678   +/-   ##
=======================================
  Coverage   34.86%   34.86%           
=======================================
  Files        1031     1031           
  Lines       27433    27433           
  Branches     2262     2262           
=======================================
  Hits         9565     9565           
  Misses      17358    17358           
  Partials      510      510           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisleewilcox chrisleewilcox added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 3, 2023
Copy link

sonarcloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@chrisleewilcox chrisleewilcox removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 3, 2023
Copy link
Member

@Andepande Andepande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox merged commit b49f4fd into main Nov 3, 2023
26 checks passed
@chrisleewilcox chrisleewilcox deleted the chore/remove-init-launchApp branch November 3, 2023 16:56
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2023
@metamaskbot metamaskbot added the release-7.11.0 Issue or pull request that will be included in release 7.11.0 label Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E2E release-7.11.0 Issue or pull request that will be included in release 7.11.0 team-mobile-platform type-bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants