-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove init launch app #7678
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fc6970c2-339f-4b95-a2ef-f8042abc3b83 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7678 +/- ##
=======================================
Coverage 34.86% 34.86%
=======================================
Files 1031 1031
Lines 27433 27433
Branches 2262 2262
=======================================
Hits 9565 9565
Misses 17358 17358
Partials 510 510 ☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Our automated tests are launching the app multiple times at the start of the tests. To improve performance and stability of tests the tests should only launch the app once at the beginning of tests.
Didn't remove
init.js
because there is an error that occurs when running tests withoutinit.js
.Related issues
Fixes: #https://github.com/MetaMask/mobile-planning/issues/1348
Manual testing steps
Screenshots/Recordings
Before
App would launch twice at the start of tests.
After
App launches only once at the start of tests.
Pre-merge author checklist
Pre-merge reviewer checklist