-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 942 invalid QR code warning message on bad QR code #7683
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dd33f0fa-4a65-4ffc-951a-a287070ccdb7 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7683 +/- ##
=======================================
Coverage 34.86% 34.86%
=======================================
Files 1031 1031
Lines 27433 27433
Branches 2262 2262
=======================================
Hits 9565 9565
Misses 17358 17358
Partials 510 510
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a suggestion about the Route const to use.
Otherwise looks good 👍
9dd9af1
to
507dcfd
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
When trying to scan an invalid QR code (e.g. not an address) from the home screen, the QR scanner was scanning and then just closing without providing any feedback to the user. This PR adds a warning to the user that they have scanned an invalid QR code.
Related issues
Fixes: 942
Manual testing steps
Steps to test:
Regression test:
Screenshots/Recordings
Before
fail.mp4
After
success.mp4
Pre-merge author checklist
Pre-merge reviewer checklist