Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 942 invalid QR code warning message on bad QR code #7683

Merged
merged 7 commits into from
Nov 7, 2023

Conversation

frankvonhoven
Copy link
Contributor

Description

When trying to scan an invalid QR code (e.g. not an address) from the home screen, the QR scanner was scanning and then just closing without providing any feedback to the user. This PR adds a warning to the user that they have scanned an invalid QR code.

Related issues

Fixes: 942

Manual testing steps

Steps to test:

  1. On the Main Wallet view tap the Scan Icon on the top right
  2. Scan this invalid QR code https://www.screencast.com/t/qhiE60jx on Networks , Ethereum, Polygon, Binance and Avalanche.
  3. Should see a popup warning that the QR code is invalid

Regression test:

  1. Scan a valid QR address code
  2. Should go to SendTo flow with address populated

Screenshots/Recordings

Before

fail.mp4

After

success.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@frankvonhoven frankvonhoven added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-client labels Nov 3, 2023
@frankvonhoven frankvonhoven requested a review from a team as a code owner November 3, 2023 15:49
Copy link
Contributor

github-actions bot commented Nov 3, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Nov 3, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dd33f0fa-4a65-4ffc-951a-a287070ccdb7
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a803ec8) 34.86% compared to head (33b4a10) 34.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7683   +/-   ##
=======================================
  Coverage   34.86%   34.86%           
=======================================
  Files        1031     1031           
  Lines       27433    27433           
  Branches     2262     2262           
=======================================
  Hits         9565     9565           
  Misses      17358    17358           
  Partials      510      510           
Files Coverage Δ
app/components/UI/Navbar/index.js 21.69% <ø> (ø)
app/components/Views/QRScanner/index.tsx 2.85% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jpcloureiro jpcloureiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion about the Route const to use.

Otherwise looks good 👍

app/components/UI/Navbar/index.js Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@frankvonhoven frankvonhoven merged commit 6697afb into main Nov 7, 2023
25 checks passed
@frankvonhoven frankvonhoven deleted the fix/942-invalid-qr-code-warning branch November 7, 2023 16:26
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 7, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready-for-dev release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants