Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor selectors and fix request token test #7687

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

chrisleewilcox
Copy link
Contributor

@chrisleewilcox chrisleewilcox commented Nov 4, 2023

Description

Refactor selectors for /e2e/pages/RequestPaymentView.js.

Fixed issue with /e2e/specs/wallet/request-token-flow.spec.js and how it was using fixtures.

Related issues

Fixes: #7558

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Passed regression: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/da4ca135-c650-4f78-a5b7-b15e50b98ed7

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Nov 4, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ee98179) 34.84% compared to head (f64a8a5) 34.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7687   +/-   ##
=======================================
  Coverage   34.84%   34.84%           
=======================================
  Files        1030     1030           
  Lines       27425    27425           
  Branches     2262     2262           
=======================================
  Hits         9557     9557           
  Misses      17358    17358           
  Partials      510      510           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisleewilcox chrisleewilcox marked this pull request as ready for review November 4, 2023 04:56
@chrisleewilcox chrisleewilcox requested a review from a team as a code owner November 4, 2023 04:56
Copy link
Contributor

github-actions bot commented Nov 4, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cffbbe97-cd46-4945-987d-ea7049e1cb76
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@chrisleewilcox chrisleewilcox changed the title chore: refactor selectors and fix request token test fix: refactor selectors and fix request token test Nov 4, 2023
Copy link

sonarcloud bot commented Nov 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@chrisleewilcox chrisleewilcox added the tests Test related issues label Nov 5, 2023
Copy link
Member

@Andepande Andepande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox merged commit 50c4186 into main Nov 6, 2023
29 checks passed
@chrisleewilcox chrisleewilcox deleted the fix/request-token-tests branch November 6, 2023 15:27
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2023
@metamaskbot metamaskbot added the release-7.11.0 Issue or pull request that will be included in release 7.11.0 label Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E2E release-7.11.0 Issue or pull request that will be included in release 7.11.0 team-mobile-platform tech-debt tests Test related issues type-bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all instances of TestIDs in page objects
5 participants