-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor selectors and fix request token test #7687
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7687 +/- ##
=======================================
Coverage 34.84% 34.84%
=======================================
Files 1030 1030
Lines 27425 27425
Branches 2262 2262
=======================================
Hits 9557 9557
Misses 17358 17358
Partials 510 510 ☔ View full report in Codecov by Sentry. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cffbbe97-cd46-4945-987d-ea7049e1cb76 |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Refactor selectors for
/e2e/pages/RequestPaymentView.js
.Fixed issue with
/e2e/specs/wallet/request-token-flow.spec.js
and how it was using fixtures.Related issues
Fixes: #7558
Manual testing steps
Screenshots/Recordings
Before
After
Passed regression: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/da4ca135-c650-4f78-a5b7-b15e50b98ed7
Pre-merge author checklist
Pre-merge reviewer checklist