Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor swaps view with selectors #7688

Merged
merged 8 commits into from
Nov 6, 2023

Conversation

chrisleewilcox
Copy link
Contributor

@chrisleewilcox chrisleewilcox commented Nov 5, 2023

Description

  • Refactored swaps tests and views
  • Added selectors file for swaps
  • Fixed flakyness with swaps tests
  • Added swap test to smoke tests suite

Related issues

Fixes: #7558

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

image

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@chrisleewilcox chrisleewilcox self-assigned this Nov 5, 2023
Copy link
Contributor

github-actions bot commented Nov 5, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4217a2d) 34.85% compared to head (fc306e8) 35.10%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7688      +/-   ##
==========================================
+ Coverage   34.85%   35.10%   +0.24%     
==========================================
  Files        1030     1032       +2     
  Lines       27426    27447      +21     
  Branches     2262     2263       +1     
==========================================
+ Hits         9560     9635      +75     
+ Misses      17357    17302      -55     
- Partials      509      510       +1     
Files Coverage Δ
app/components/UI/AccountApproval/index.js 45.90% <100.00%> (+38.35%) ⬆️
app/constants/urls.ts 100.00% <100.00%> (ø)
app/components/UI/AccountApproval/styles.ts 66.66% <66.66%> (ø)
...omponents/UI/AccountApproval/showWarningBanner.tsx 77.77% <77.77%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisleewilcox chrisleewilcox marked this pull request as ready for review November 5, 2023 17:12
@chrisleewilcox chrisleewilcox requested a review from a team as a code owner November 5, 2023 17:12
Copy link
Contributor

github-actions bot commented Nov 5, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0efe06f5-a14c-431d-ba4b-ed31746ad062
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@chrisleewilcox chrisleewilcox added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 5, 2023
@chrisleewilcox
Copy link
Contributor Author

Copy link

sonarcloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@Andepande Andepande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@chrisleewilcox chrisleewilcox merged commit 819a17f into main Nov 6, 2023
24 checks passed
@chrisleewilcox chrisleewilcox deleted the chore/refactor-swaps-view-with-selectors branch November 6, 2023 17:05
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 6, 2023
@metamaskbot metamaskbot added the release-7.11.0 Issue or pull request that will be included in release 7.11.0 label Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E2E release-7.11.0 Issue or pull request that will be included in release 7.11.0 team-mobile-platform tech-debt tests Test related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all instances of TestIDs in page objects
6 participants