Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: logger.js to typescript and optimize for dev #7704

Merged
merged 1 commit into from
Nov 7, 2023
Merged

refactor: logger.js to typescript and optimize for dev #7704

merged 1 commit into from
Nov 7, 2023

Conversation

abretonc7s
Copy link
Contributor

@abretonc7s abretonc7s commented Nov 7, 2023 •
edited

Description

  • Migrate Logger.js to typescript
  • Optimize for faster output in dev
    Previously the logger would start by synchronously accessing user preferences even in dev which is unnecessary since logs won't be sent to server.
    It would also mess up the order of logs being printed depending on the time it takes to access the DefaultPreferences.

Related issues

Fixes: #

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@abretonc7s abretonc7s changed the title refactor refactor logger.js to typescript and optimize for dev refactorlogger.js to typescript and optimize for dev Nov 7, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@abretonc7s abretonc7s marked this pull request as ready for review November 7, 2023 08:02
@abretonc7s abretonc7s requested a review from a team as a code owner November 7, 2023 08:02
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f095d197-8c36-4179-b6f0-5230f73d8837
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

andreahaku
andreahaku approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abretonc7s abretonc7s changed the title refactorlogger.js to typescript and optimize for dev refactor: logger.js to typescript and optimize for dev Nov 7, 2023
@abretonc7s abretonc7s marked this pull request as draft November 7, 2023 10:06
@abretonc7s abretonc7s marked this pull request as ready for review November 7, 2023 10:36
@abretonc7s abretonc7s changed the title refactor: logger.js to typescript and optimize for dev feat: logger.js to typescript and optimize for dev Nov 7, 2023
@abretonc7s abretonc7s changed the title feat: logger.js to typescript and optimize for dev refactor: logger.js to typescript and optimize for dev Nov 7, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

14.3% 14.3% Coverage
0.0% 0.0% Duplication

tommasini
tommasini approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc: @Cal-L for visibility, since there are work being planned to change this logger file

@abretonc7s abretonc7s merged commit 1ac73f8 into main Nov 7, 2023
32 of 33 checks passed
@abretonc7s abretonc7s deleted the refactor/logger branch November 7, 2023 13:22
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreahaku andreahaku andreahaku approved these changes

@tommasini tommasini tommasini approved these changes

Assignees

@andreahaku andreahaku

@omridan159 omridan159

Labels
release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@abretonc7s @andreahaku @tommasini @metamaskbot @omridan159