Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PPOM - See details arrow icon missmatch between platforms #7706

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

blackdevelopa
Copy link
Contributor

@blackdevelopa blackdevelopa commented Nov 7, 2023

Description

In this reported issue, #7514, the accordion icon doesn't seem aligned to the extension. This small fix should take care of it.

Related issues

Fixes: #7514
Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dc0c23c8-8764-4dcf-918f-a56ba86750b5

Manual testing steps

  1. Enable Blockaid
  2. Go to the test dapp
  3. Trigger a malicious signature
  4. See arrow

Screenshots/Recordings

Before

Screenshot 2023-11-07 at 11 14 16

After

https://recordit.co/VXwtIOPJSN

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@blackdevelopa blackdevelopa self-assigned this Nov 7, 2023
Copy link
Contributor

github-actions bot commented Nov 7, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa added the team-confirmations-secure-ux-PR PR from the confirmations team label Nov 7, 2023
@blackdevelopa blackdevelopa marked this pull request as ready for review November 7, 2023 10:15
@blackdevelopa blackdevelopa requested a review from a team as a code owner November 7, 2023 10:15
Copy link
Contributor

github-actions bot commented Nov 7, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/14bc7fbd-a52e-48ff-bfa0-bb64a7e0c687
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4bcefa9) 34.99% compared to head (ba30a9b) 35.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7706   +/-   ##
=======================================
  Coverage   34.99%   35.00%           
=======================================
  Files        1034     1034           
  Lines       27548    27550    +2     
  Branches     2284     2284           
=======================================
+ Hits         9641     9643    +2     
  Misses      17396    17396           
  Partials      511      511           
Files Coverage Δ
...ion/foundation/AccordionHeader/AccordionHeader.tsx 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianacnguyen brianacnguyen merged commit 6126c94 into main Nov 7, 2023
37 checks passed
@brianacnguyen brianacnguyen deleted the 7514-accordion-icon-mismatch branch November 7, 2023 17:04
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PPOM - See details arrow icon missmatch between platforms
5 participants