feat: configure metro listener port

[abretonc7s]

Description

You may want to run multiple instance of the wallet for debug purposes and to enable this, you will need to configure metro on different port. This PR allows you to run the wallet without conflicting with other react native apps.

WATCHER_PORT=8082 yarn start:ios

You can also directly edit with .js.env with:

export WATCHER_PORT=8081

Related issues

Fixes: #

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4e2e2aac-f177-49be-b664-9548c637ce4f
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

[github-actions]

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1f4ef5db-d802-4f42-a739-67fd442287fa
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

[tommasini]

instead of WATCHER_PORT=8082 yarn start:ios, could we create a script on our package.json with it? It will be easier to use on the future
something like "yarn start:ios:8082": "WATCHER_PORT=8082 yarn start:ios"

[abretonc7s]

instead of WATCHER_PORT=8082 yarn start:ios, could we create a script on our package.json with it? It will be easier to use on the future something like "yarn start:ios:8082": "WATCHER_PORT=8082 yarn start:ios"

I think it would make it less convenient and would also hardcode specific other ports to the rules. Using env allows using any port and just export WATCHER_PORT=1111 separately

[tommasini]

LGTM!

[tommasini]

LGTM!

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7524a07) 35.00% compared to head (9c35646) 35.00%.

❗ Current head 9c35646 differs from pull request most recent head c0d77a2. Consider uploading reports for the commit c0d77a2 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7708   +/-   ##
=======================================
  Coverage   35.00%   35.00%           
=======================================
  Files        1034     1034           
  Lines       27550    27550           
  Branches     2284     2284           
=======================================
  Hits         9643     9643           
  Misses      17396    17396           
  Partials      511      511           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tommasini]

Cool, thanks for updating the readme as well!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information