Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add definitions for release labels in labeling-guidelines #7718

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

gauthierpetetin
Copy link
Contributor

@gauthierpetetin gauthierpetetin commented Nov 7, 2023

Description

Add definitions for release-x.y.z and regression-prod-x.y.z labels

Related issues

  • NA

Manual testing steps

Screenshots/Recordings

  • NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gauthierpetetin gauthierpetetin requested a review from a team as a code owner November 7, 2023 21:18
Copy link
Contributor

github-actions bot commented Nov 7, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Nov 7, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/66f0911b-09c4-44fc-9549-55b1e3f73e0e
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86a6593) 34.99% compared to head (d0c1687) 34.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7718   +/-   ##
=======================================
  Coverage   34.99%   34.99%           
=======================================
  Files        1034     1034           
  Lines       27537    27537           
  Branches     2298     2298           
=======================================
  Hits         9637     9637           
  Misses      17387    17387           
  Partials      513      513           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gauthierpetetin gauthierpetetin changed the title fix:labeling-guidelines add definitions for release labels fix: add definitions for release labels in labeling-guidelines Nov 8, 2023
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gauthierpetetin gauthierpetetin merged commit f118757 into main Nov 8, 2023
51 of 53 checks passed
@gauthierpetetin gauthierpetetin deleted the fix/labeling-guidelines branch November 8, 2023 18:52
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants