Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bitrise android e2e linux builds #7719

Merged
merged 31 commits into from
Nov 8, 2023
Merged

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Nov 7, 2023

Description

This PR uses asdf to install node and yarn versions during build setup. Yarn setup was failing due to mismatch of node versions. The root cause was traced down to Bitrise updating the configuration of the linux image used to in the android builds. The specific node version did not have yarn installed by default which cause the yarn setup step to fail.

Related issues

Fixes: NA

Manual testing steps

  1. Run this PR using the smoke test E2E workflow and it should pass.

Screenshots/Recordings

NA

Before

Failing E2E: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0501526b-ecd8-447d-b176-d6834586079c

After

Passing E2E in comments below

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sethkfman sethkfman requested a review from a team as a code owner November 7, 2023 23:06
Copy link
Contributor

github-actions bot commented Nov 7, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Nov 7, 2023
Copy link
Contributor

github-actions bot commented Nov 7, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/86476392-28b4-44d8-9c8d-1515da174b1d
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Andepande Andepande merged commit 2f7314f into main Nov 8, 2023
61 of 64 checks passed
@Andepande Andepande deleted the fix/bitrise-android-linux-builds branch November 8, 2023 10:36
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2023
@metamaskbot metamaskbot added release-7.12.0 Issue or pull request that will be included in release 7.12.0 in-progress labels Nov 8, 2023
@gauthierpetetin gauthierpetetin added release-7.11.0 Issue or pull request that will be included in release 7.11.0 and removed in-progress release-7.12.0 Issue or pull request that will be included in release 7.12.0 labels Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.11.0 Issue or pull request that will be included in release 7.11.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants