Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Move testIDs from the last 10 files from the modals folder #7720

Merged
merged 5 commits into from
Nov 8, 2023

Conversation

SamuelSalas
Copy link
Member

@SamuelSalas SamuelSalas commented Nov 7, 2023

Description

Relocate the TestIDs from each page object to their corresponding testID file within the testID folder. This task is aimed at transferring the TestIDs from the last page objects in the modals folder.

Related issues

Fixes: #7560

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@SamuelSalas SamuelSalas self-assigned this Nov 7, 2023
@SamuelSalas SamuelSalas requested a review from a team as a code owner November 7, 2023 23:23
@SamuelSalas SamuelSalas linked an issue Nov 7, 2023 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Nov 7, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6897f769-736b-43d1-bca4-3f54206381c1
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@metamaskbot metamaskbot added in-progress needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed in-progress labels Nov 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6fed1c8) 34.99% compared to head (56c75b3) 34.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7720      +/-   ##
==========================================
- Coverage   34.99%   34.97%   -0.02%     
==========================================
  Files        1034     1034              
  Lines       27537    27529       -8     
  Branches     2298     2298              
==========================================
- Hits         9637     9629       -8     
  Misses      17387    17387              
  Partials      513      513              
Files Coverage Δ
app/components/UI/MessageSign/MessageSign.tsx 68.29% <ø> (ø)
app/components/UI/PersonalSign/PersonalSign.tsx 74.50% <ø> (ø)
app/components/UI/ProtectYourWalletModal/index.js 26.08% <ø> (ø)
app/components/UI/ReceiveRequest/index.js 9.43% <ø> (ø)
app/components/UI/SignatureRequest/index.js 57.14% <ø> (ø)
app/components/UI/TypedSign/index.js 66.07% <ø> (ø)
app/components/UI/WatchAssetRequest/index.js 13.04% <ø> (ø)
app/components/UI/WhatsNewModal/WhatsNewModal.tsx 20.00% <ø> (ø)
app/constants/test-ids.js 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelSalas SamuelSalas changed the title Move testIDs from the last 10 files from the modals folder test: Move testIDs from the last 10 files from the modals folder Nov 7, 2023
Copy link
Contributor

github-actions bot commented Nov 8, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/97501c72-917a-4759-9d1b-0da63f14c159
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@Andepande Andepande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SamuelSalas SamuelSalas merged commit 351778e into main Nov 8, 2023
26 checks passed
@SamuelSalas SamuelSalas deleted the test/7560-move-testids-from-modals-folder branch November 8, 2023 21:58
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move TestIDs from page objects in modals folder
5 participants