-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: silence PollingBlockTracker Sentry error emit #7733
fix: silence PollingBlockTracker Sentry error emit #7733
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f2fd964b-7888-4df9-bd6b-ec9e1ba2d01d |
…to fix/7579-PollingBlockTracker-failed-call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7733 +/- ##
=======================================
Coverage 35.09% 35.09%
=======================================
Files 1035 1035
Lines 27526 27526
Branches 2311 2311
=======================================
Hits 9661 9661
Misses 17345 17345
Partials 520 520 ☔ View full report in Codecov by Sentry. |
Could we also provide evidence showing that these aren't broken since PollingBlockTracker is used by both network controller and transaction controller?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@frankvonhoven @Cal-L I moved this back to dev review. E2E failed to build. Can you update branch and rerun E2E for this PR? |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Related issues
Fixes: #7579
Manual testing steps
Screenshots/Recordings
Switch Networks
switch-network.mp4
Swap
swap.mp4
Send
send.mp4
Transaction History
history.mp4
Pre-merge author checklist
Pre-merge reviewer checklist