Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: silence PollingBlockTracker Sentry error emit #7733

Merged
merged 6 commits into from
Nov 10, 2023

Conversation

frankvonhoven
Copy link
Contributor

@frankvonhoven frankvonhoven commented Nov 8, 2023

Description

  1. What is the reason for the change?
  • Sentry PollingBlockTracker errors were very noisy (see related issue)
  1. What is the improvement/solution?
  • Silencing the unhandled error as we weren't able to determine sources of errors
  • Patch the web3-provider-engine node module with change
  • The PollingBlockTracker will be replaced in the network-controller v9 - which is expected to be released soon

Related issues

Fixes: #7579

Manual testing steps

  1. Switch between networks
  2. Swap some crypto
  3. Send some crypto
  4. Shouldn't see any PollingBlockTracker errors like in the related issue in Sentry

Screenshots/Recordings

Switch Networks

switch-network.mp4

Swap

swap.mp4

Send

send.mp4

Transaction History

history.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@frankvonhoven frankvonhoven added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-client labels Nov 8, 2023
@frankvonhoven frankvonhoven requested a review from a team as a code owner November 8, 2023 19:11
Copy link
Contributor

github-actions bot commented Nov 8, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Nov 8, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f2fd964b-7888-4df9-bd6b-ec9e1ba2d01d
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

…to fix/7579-PollingBlockTracker-failed-call
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment

patches/web3-provider-engine+16.0.5.patch Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b9088e7) 35.09% compared to head (52a9410) 35.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7733   +/-   ##
=======================================
  Coverage   35.09%   35.09%           
=======================================
  Files        1035     1035           
  Lines       27526    27526           
  Branches     2311     2311           
=======================================
  Hits         9661     9661           
  Misses      17345    17345           
  Partials      520      520           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cal-L
Copy link
Contributor

Cal-L commented Nov 8, 2023

Could we also provide evidence showing that these aren't broken since PollingBlockTracker is used by both network controller and transaction controller?

  • Switching networks between testnets as well as other chains such as BNB, polygon, etc
  • Ensuring that transaction history still appears properly in the activity view
  • Perform some transactions on mainnet such as send, swap, etc

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot metamaskbot added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Nov 9, 2023
@chrisleewilcox chrisleewilcox added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 9, 2023
@chrisleewilcox
Copy link
Contributor

@frankvonhoven @Cal-L I moved this back to dev review. E2E failed to build. Can you update branch and rerun E2E for this PR?

Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@metamaskbot metamaskbot added ready-for-dev needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) ready-for-dev labels Nov 9, 2023
@chrisleewilcox chrisleewilcox removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Nov 10, 2023
@chrisleewilcox chrisleewilcox added the QA in Progress QA has started on the feature. label Nov 10, 2023
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@chrisleewilcox chrisleewilcox added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Nov 10, 2023
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox merged commit af0336f into main Nov 10, 2023
40 of 42 checks passed
@chrisleewilcox chrisleewilcox deleted the fix/7579-PollingBlockTracker-failed-call branch November 10, 2023 21:19
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sentry] [BUG] Error: PollingBlockTracker - encountered an error while attempting to update latest block:
6 participants