Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reduce e2e build scenarios #7735

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Nov 8, 2023

Description

Since we're seeing our Bitrise credits drained relatively quickly, this PR removes the opened and reopened scenarios for triggering e2e smoke tests. The remaining ways to trigger e2e smoke tests are ready_for_review and labeled.

Related issues

Fixes: #

Manual testing steps

ready_for_review - Change this PR to draft and back to ready for review
labeled - Apply the Run E2E Smoke label

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested a review from a team as a code owner November 8, 2023 22:17
Copy link
Contributor

github-actions bot commented Nov 8, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L changed the title Reduce e2e build scenarios chore: Reduce e2e build scenarios Nov 8, 2023
@Cal-L Cal-L added team-mobile-client No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. labels Nov 8, 2023
@metamaskbot metamaskbot added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 8, 2023
Copy link
Contributor

github-actions bot commented Nov 8, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/29c1057d-f4a3-408a-bfda-c61fd2a26cb7
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac970da) 34.99% compared to head (7aa8473) 34.97%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7735      +/-   ##
==========================================
- Coverage   34.99%   34.97%   -0.02%     
==========================================
  Files        1034     1034              
  Lines       27537    27529       -8     
  Branches     2298     2298              
==========================================
- Hits         9637     9629       -8     
  Misses      17387    17387              
  Partials      513      513              

see 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L merged commit 5aaf054 into main Nov 9, 2023
39 of 40 checks passed
@Cal-L Cal-L deleted the chore/update-smoke-run-scenarios branch November 9, 2023 01:23
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 9, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants