Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update ListItem based on latest design #7739

Merged
merged 10 commits into from
Nov 9, 2023

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Nov 9, 2023

Description

  • Moved padding and borderRadius to style
  • Updated default verticalAlignment to center

Screenshots/Recordings

Simulator Screen Shot - iPhone 14 Pro - 2023-11-09 at 08 10 47
Simulator Screen Shot - iPhone 14 Pro - 2023-11-09 at 10 19 51
Simulator Screen Shot - iPhone 14 Pro - 2023-11-09 at 10 20 15
Simulator Screen Shot - iPhone 14 Pro - 2023-11-09 at 10 24 56
Uploading Simulator Screen Shot - iPhone 14 Pro - 2023-11-09 at 10.25.03.png…

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile labels Nov 9, 2023
@brianacnguyen brianacnguyen self-assigned this Nov 9, 2023
@brianacnguyen brianacnguyen requested a review from a team as a code owner November 9, 2023 16:05
Copy link
Contributor

github-actions bot commented Nov 9, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb37fdf) 35.10% compared to head (b3c5c9d) 35.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7739      +/-   ##
==========================================
- Coverage   35.10%   35.09%   -0.01%     
==========================================
  Files        1035     1035              
  Lines       27529    27526       -3     
  Branches     2313     2311       -2     
==========================================
- Hits         9664     9661       -3     
  Misses      17345    17345              
  Partials      520      520              
Files Coverage Δ
...ary/components/List/ListItem/ListItem.constants.ts 100.00% <100.00%> (ø)
...rary/components/List/ListItem/ListItem.stories.tsx 0.00% <ø> (ø)
...ibrary/components/List/ListItem/ListItem.styles.ts 70.00% <100.00%> (ø)
...nent-library/components/List/ListItem/ListItem.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Brian amazing work, can you record a video of the permissions components? I can see that this impacts the permissions sheets for connecting one or multiple accounts to a dapp

@brianacnguyen
Copy link
Contributor Author

Hey Brian amazing work, can you record a video of the permissions components? I can see that this impacts the permissions sheets for connecting one or multiple accounts to a dapp

done

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please merge it after the E2E pass please!

Copy link
Contributor

github-actions bot commented Nov 9, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0de758d0-90f9-4a41-891b-65bfa0193d13
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@brianacnguyen brianacnguyen merged commit b9088e7 into main Nov 9, 2023
32 checks passed
@brianacnguyen brianacnguyen deleted the morph/update-listitem branch November 9, 2023 18:31
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 9, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-7.12.0 Issue or pull request that will be included in release 7.12.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants