-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Update ListItem based on latest design #7739
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…to morph/update-listitem
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7739 +/- ##
==========================================
- Coverage 35.10% 35.09% -0.01%
==========================================
Files 1035 1035
Lines 27529 27526 -3
Branches 2313 2311 -2
==========================================
- Hits 9664 9661 -3
Misses 17345 17345
Partials 520 520
☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Brian amazing work, can you record a video of the permissions components? I can see that this impacts the permissions sheets for connecting one or multiple accounts to a dapp
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please merge it after the E2E pass please!
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0de758d0-90f9-4a41-891b-65bfa0193d13 |
Description
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist