Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update SelectItem #7741

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Nov 9, 2023

Description

  • Renamed SelectItem to ListItemSelect
  • Updated usage

Screenshots/Recordings

Simulator Screen Shot - iPhone 14 Pro - 2023-11-09 at 10 50 39

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile Run Smoke E2E labels Nov 9, 2023
@brianacnguyen brianacnguyen self-assigned this Nov 9, 2023
@brianacnguyen brianacnguyen requested a review from a team as a code owner November 9, 2023 18:46
Copy link
Contributor

github-actions bot commented Nov 9, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 9, 2023
Copy link
Contributor

github-actions bot commented Nov 9, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9a3fc561-7519-4bdd-be7b-1d49211b55e6
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

84.6% 84.6% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b9088e7) 35.09% compared to head (a03fa7a) 35.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7741      +/-   ##
==========================================
- Coverage   35.09%   35.09%   -0.01%     
==========================================
  Files        1035     1035              
  Lines       27526    27525       -1     
  Branches     2311     2312       +1     
==========================================
- Hits         9661     9660       -1     
  Misses      17345    17345              
  Partials      520      520              
Files Coverage Δ
...ents/Cells/Cell/variants/CellSelect/CellSelect.tsx 100.00% <ø> (ø)
...ts/List/ListItemSelect/ListItemSelect.constants.ts 100.00% <100.00%> (ø)
...nents/List/ListItemSelect/ListItemSelect.styles.ts 83.33% <ø> (ø)
.../components/List/ListItemSelect/ListItemSelect.tsx 100.00% <100.00%> (ø)
...nts/List/ListItemSelect/ListItemSelect.stories.tsx 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianacnguyen brianacnguyen merged commit 8522e9d into main Nov 9, 2023
26 checks passed
@brianacnguyen brianacnguyen deleted the morph/update-selectlistitem branch November 9, 2023 19:58
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 9, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-7.12.0 Issue or pull request that will be included in release 7.12.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants