-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add a section for stakeholder reviews in issue template #7745
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gauthierpetetin can we re-word avoid QA statement? We want to encourage a thoughtful process for teams to make a sufficient determination if a PR should go to QA or if it's not necessary. Something like...
"Automation tests are required to pass before merging PRs but not all changes are covered by automation tests. Please review if QA is needed beyond automation tests."
@chrisleewilcox yes that makes sense, it's updated now. Thanks for the review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7745 +/- ##
=======================================
Coverage 37.39% 37.39%
=======================================
Files 1052 1052
Lines 28175 28175
Branches 2517 2517
=======================================
Hits 10536 10536
Misses 17040 17040
Partials 599 599 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change going to be clear enough for external users?
Should we add something like "leave this blank if you are not part of MM team"? and then check the box on our side when we qualify issues?
@NicolasMassart , yes good point, it is updated now |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Adds a section for "stakeholder reviews" in general issue template.
This gives the opportunity to indicate, when creating a new issue, if the work needs to be reviewed by specific stakeholders before being merged.
Same PR for Extension
Related issues
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist