Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a section for stakeholder reviews in issue template #7745

Merged
merged 5 commits into from
Nov 28, 2023

Conversation

gauthierpetetin
Copy link
Contributor

@gauthierpetetin gauthierpetetin commented Nov 9, 2023

Description

Adds a section for "stakeholder reviews" in general issue template.
This gives the opportunity to indicate, when creating a new issue, if the work needs to be reviewed by specific stakeholders before being merged.

Same PR for Extension

Related issues

  • NA

Manual testing steps

  1. Go to this test repo
  2. Create a new issue

Screenshots/Recordings

Screenshot 2023-11-09 at 18 02 44

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gauthierpetetin gauthierpetetin requested a review from a team as a code owner November 9, 2023 21:11
Copy link
Contributor

github-actions bot commented Nov 9, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gauthierpetetin gauthierpetetin changed the title fix(issue-template): add a section for stakeholder reviews fix: add a section for stakeholder reviews in issue template Nov 9, 2023
Cal-L
Cal-L previously approved these changes Nov 9, 2023
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gauthierpetetin can we re-word avoid QA statement? We want to encourage a thoughtful process for teams to make a sufficient determination if a PR should go to QA or if it's not necessary. Something like...
"Automation tests are required to pass before merging PRs but not all changes are covered by automation tests. Please review if QA is needed beyond automation tests."

@metamaskbot metamaskbot added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 15, 2023
@gauthierpetetin
Copy link
Contributor Author

@chrisleewilcox yes that makes sense, it's updated now. Thanks for the review.

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69c79df) 37.39% compared to head (a7e2460) 37.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7745   +/-   ##
=======================================
  Coverage   37.39%   37.39%           
=======================================
  Files        1052     1052           
  Lines       28175    28175           
  Branches     2517     2517           
=======================================
  Hits        10536    10536           
  Misses      17040    17040           
  Partials      599      599           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change going to be clear enough for external users?
Should we add something like "leave this blank if you are not part of MM team"? and then check the box on our side when we qualify issues?

@gauthierpetetin
Copy link
Contributor Author

@NicolasMassart , yes good point, it is updated now

Copy link

sonarcloud bot commented Nov 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gauthierpetetin gauthierpetetin merged commit 51199b5 into main Nov 28, 2023
26 checks passed
@gauthierpetetin gauthierpetetin deleted the fix/issue-template-stakeholer-review branch November 28, 2023 09:51
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 28, 2023
@metamaskbot metamaskbot added the release-7.13.0 Issue or pull request that will be included in release 7.13.0 label Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.13.0 Issue or pull request that will be included in release 7.13.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants