Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: undo QR code changes from previous merge #7749

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

frankvonhoven
Copy link
Contributor

@frankvonhoven frankvonhoven commented Nov 9, 2023

Description

This hotfix reverts an intended fix for related issue below

Related issues

Fixes: #942

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Video of scan of QR code with original crash on scan:

Screen_Recording_20231110_012216_MetaMask.mp4

Scan of QR code from Omri:

Screen_Recording_20231111_003601_MetaMask.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@frankvonhoven frankvonhoven requested a review from a team as a code owner November 9, 2023 23:28
Copy link
Contributor

github-actions bot commented Nov 9, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@frankvonhoven frankvonhoven added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-client labels Nov 9, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4770023) 35.09% compared to head (952191a) 35.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7749   +/-   ##
=======================================
  Coverage   35.09%   35.09%           
=======================================
  Files        1035     1035           
  Lines       27523    27523           
  Branches     2312     2312           
=======================================
  Hits         9658     9658           
  Misses      17345    17345           
  Partials      520      520           
Files Coverage Δ
app/components/UI/Navbar/index.js 21.69% <ø> (ø)
app/components/Views/QRScanner/index.tsx 2.85% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cal-L
Copy link
Contributor

Cal-L commented Nov 9, 2023

Could you provide a video showing this scenario is fixed? https://consensys.slack.com/archives/C02U025CVU4/p1699532816609679

Copy link

sonarcloud bot commented Nov 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@frankvonhoven frankvonhoven merged commit 4d74ecb into main Nov 13, 2023
30 checks passed
@frankvonhoven frankvonhoven deleted the revert/942-invalid-qr-code-warning branch November 13, 2023 16:17
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 13, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants