Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert the changes made for deeplink. #7765

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

segun
Copy link
Contributor

@segun segun commented Nov 11, 2023

Description

This reverts this commit because it affects the Send/Confirm screens and we are not sure if we want to enable PPOM for these screens yet

Related issues

Fixes: #

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@segun segun added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team labels Nov 11, 2023
@segun segun self-assigned this Nov 11, 2023
@segun segun requested a review from a team as a code owner November 11, 2023 14:44
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (facb802) 35.08% compared to head (f056a5d) 35.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7765      +/-   ##
==========================================
- Coverage   35.08%   35.08%   -0.01%     
==========================================
  Files        1039     1039              
  Lines       27634    27627       -7     
  Branches     2336     2336              
==========================================
- Hits         9695     9692       -3     
+ Misses      17416    17412       -4     
  Partials      523      523              
Files Coverage Δ
app/components/Views/Send/index.js 3.77% <ø> (+0.06%) ⬆️
app/components/Views/SendFlow/Confirm/index.js 43.43% <ø> (-0.62%) ⬇️
app/components/Views/SendFlow/Confirm/styles.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@segun segun changed the title Revert the changes made for deeplink. fix: revert the changes made for deeplink. Nov 11, 2023
@segun segun merged commit 88c4183 into main Nov 14, 2023
34 of 35 checks passed
@segun segun deleted the olu/revert-deeplink-fix branch November 14, 2023 10:37
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 14, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants