fix: WalletConnect requests should show loading banner for blockaid.

[segun]

Description

Make PPOM validations for deeplink and walletconnect async to leverage recent blockaid performance improvements

The changes to app/components/Views/QRScanner/index.tsx are necessary as it's a bug introduced by a recent commit. Details of the bug and the fix here

Related issues

Fixes: #1655

1. Checkout branch and run on real device
2. Comment out the line described here
3. Go to testdapp for wallet connect
4. Connect wallet using wallet connect
5. Perform a PPOM Transaction
6. You should see a loading banner and after a few moments see the blockaid banner (as shown in image below)

Screenshots/Recordings

Before

After

Then

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov-commenter]

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (65754d5) 35.04% compared to head (5e10a23) 35.04%.

Files	Patch %	Lines
app/core/WalletConnect/WalletConnect.js	0.00%	5 Missing ⚠️
app/core/WalletConnect/WalletConnectV2.ts	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7776      +/-   ##
==========================================
- Coverage   35.04%   35.04%   -0.01%     
==========================================
  Files        1040     1040              
  Lines       27709    27713       +4     
  Branches     2344     2343       -1     
==========================================
  Hits         9711     9711              
- Misses      17474    17478       +4     
  Partials      524      524              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jpuri]

Changes look good, will be great if some unit test coverage can also be added to it.

[blackdevelopa]

@segun, it seems bitrise is failing. Can you update branch and retry?

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[segun]

Bitrise https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/009996a4-a89d-4719-aec8-bf60dca596f2