Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e - update search asset and hide for wallet tests #7786

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

chrisleewilcox
Copy link
Contributor

@chrisleewilcox chrisleewilcox commented Nov 13, 2023

Description

  • Test data for asset to select after a search recently started failing due to asset no longer showing in the search results for token import on Ethereum Mainnet. Updated to select asset currently shown on autocomplete import token.
  • Added additional it block to identify testing hide asset feature.

Related issues

Fixes: #https://github.com/MetaMask/mobile-planning/issues/1357

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@chrisleewilcox chrisleewilcox self-assigned this Nov 13, 2023
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chrisleewilcox chrisleewilcox marked this pull request as ready for review November 13, 2023 23:15
@chrisleewilcox chrisleewilcox requested a review from a team as a code owner November 13, 2023 23:15
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/603d960f-19a9-4107-b690-6fe1b9ed24c5
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa2dd58) 35.08% compared to head (b524fe4) 35.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7786   +/-   ##
=======================================
  Coverage   35.08%   35.08%           
=======================================
  Files        1039     1039           
  Lines       27628    27628           
  Branches     2336     2336           
=======================================
  Hits         9694     9694           
  Misses      17411    17411           
  Partials      523      523           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisleewilcox chrisleewilcox removed the request for review from Andepande November 14, 2023 14:40
Copy link

sonarcloud bot commented Nov 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@chrisleewilcox chrisleewilcox merged commit bffa164 into main Nov 14, 2023
26 checks passed
@chrisleewilcox chrisleewilcox deleted the fix/update-search-asset-hide branch November 14, 2023 16:21
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E2E release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants