Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove PPOM initialisation error appearing in dev mode #7788

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Nov 14, 2023

Description

Update ppom-validator to fix error to initialise PPOM in dev mode.

Related issues

Fixes: #7775

Manual testing steps

  1. Initialise the app in IOS or Android emutator
  2. Error in initialising PPOM should not be there

Screenshots/Recordings

image

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team labels Nov 14, 2023
@jpuri jpuri requested a review from a team as a code owner November 14, 2023 11:02
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri changed the title Update @metamask/ppom-validator package fix: remove PPOM initialisation error appearing in dev mode Nov 14, 2023
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/ppom-validator 0.10.0...0.11.0 None +0/-0 135 kB

Copy link

socket-security bot commented Nov 14, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @metamask/ppom-validator@0.11.0

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@jpuri
Copy link
Contributor Author

jpuri commented Nov 14, 2023

@SocketSecurity ignore @metamask/ppom-validator@0.11.0

@jpuri
Copy link
Contributor Author

jpuri commented Nov 14, 2023

Copy link

sonarcloud bot commented Nov 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (88c4183) 35.08% compared to head (7347a87) 35.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7788      +/-   ##
==========================================
- Coverage   35.08%   35.08%   -0.01%     
==========================================
  Files        1039     1039              
  Lines       27628    27628              
  Branches     2336     2336              
==========================================
- Hits         9694     9693       -1     
- Misses      17411    17412       +1     
  Partials      523      523              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpuri jpuri merged commit 5fb0605 into main Nov 14, 2023
34 of 35 checks passed
@jpuri jpuri deleted the ppom_controller_fix branch November 14, 2023 14:40
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 14, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 14, 2023
@blackdevelopa
Copy link
Contributor

Just seeing that bitrise failed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PPOM - Error trying to initialize PPOM when opening wallet
5 participants