-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove wrong property #7834
Conversation
ddb5266
to
1b7240e
Compare
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6fca9467-df4f-463c-aa18-bbba65a84466 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7834 +/- ##
=======================================
Coverage 35.04% 35.04%
=======================================
Files 1040 1040
Lines 27710 27710
Branches 2344 2344
=======================================
Hits 9711 9711
Misses 17475 17475
Partials 524 524 ☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Description
A wrong style property was causing errors on iOS and warnings on Android. It was previously attempted to be fixed by #7821 but the error continued to happen. This PR removes the incorrect property and fixes the error/warning.
More context on this slack thread: https://consensys.slack.com/archives/C02U025CVU4/p1699950726232009
The initial fix was made in this PR for off-ramp #7800
This was the error on iOS and warning on Android:
Related issues
Actually Fixes: #7816
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist