Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove wrong property #7834

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix: remove wrong property #7834

merged 1 commit into from
Nov 15, 2023

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Nov 15, 2023

Description

A wrong style property was causing errors on iOS and warnings on Android. It was previously attempted to be fixed by #7821 but the error continued to happen. This PR removes the incorrect property and fixes the error/warning.

More context on this slack thread: https://consensys.slack.com/archives/C02U025CVU4/p1699950726232009

The initial fix was made in this PR for off-ramp #7800

This was the error on iOS and warning on Android:

image
image

Related issues

Actually Fixes: #7816

Manual testing steps

  1. Sending a transaction must not cause the error

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform labels Nov 15, 2023
@wachunei wachunei requested a review from a team as a code owner November 15, 2023 20:19
@wachunei wachunei changed the title fix(ramp): remove wrong property fix: remove wrong property Nov 15, 2023
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6fca9467-df4f-463c-aa18-bbba65a84466
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca5a673) 35.04% compared to head (1b7240e) 35.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7834   +/-   ##
=======================================
  Coverage   35.04%   35.04%           
=======================================
  Files        1040     1040           
  Lines       27710    27710           
  Branches     2344     2344           
=======================================
  Hits         9711     9711           
  Misses      17475    17475           
  Partials      524      524           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@wachunei wachunei added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Nov 15, 2023
@wachunei wachunei merged commit 9ab1dd1 into main Nov 15, 2023
36 checks passed
@wachunei wachunei deleted the fix/incorrect-style-property branch November 15, 2023 21:21
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Attempting to define a property on object that is note extensible - iOs only
4 participants