feat: add bridge wallet action #7835

BZahory · 2023-11-15T20:37:25Z

Description

Motivation

Organically exposing MetaMask Mobile users to MetaMask Bridges could contribute to a company-wide initiative to close the gap between our current and targeted revenue projections. Mobile users currently only contribute ~5% of MetaMask Portfolio transactions despite mobile users making up over 62% of page views; there is an opportunity to capture a vast and wildly underrepresented market here.

Solution

Add a MetaMask Bridges wallet action

Related issues

METABRIDGE-459

Manual testing steps

Load MetaMask Mobile and set-up/create an account.
Selected a supported MetaMask Bridges chain (e.g., Ethereum Mainnet)
Tap on the wallet actions button on the bottom-middle of the home screen
- Verify that the "Bridge" row is present with a matching icon and description
Tap on the "Bridge" row
- Verify that MetaMask Bridges opens in the browser on the selected chain.
Go back to the home screen
Repeat steps 1-4
- Verify that the existing tab is reopened in the browser.
Switch to an unsupported MetaMask Bridges chain
Verify that MetaMask Bridges is no longer an available wallet action

Screenshots/Recordings

Before

After

iPhone SE

Happy path flows

Screen.Recording.2023-11-22.at.10.05.27.AM.mov

Button does not show on unsupported bridge networks

Screen.Recording.2023-11-28.at.4.00.52.PM.mov

Opening bridge with MetaMask Portfolio, Uniswap, and a non-web3 tab open

Screen.Recording.2023-11-28.at.4.06.54.PM.mov

Restarting the app with the same tabs open

Screen.Recording.2023-11-28.at.4.10.35.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2023-11-15T20:37:38Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

BZahory · 2023-11-15T21:00:48Z

I have read the CLA Document and I hereby sign the CLA

codecov-commenter · 2023-11-20T22:17:04Z

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (728ed44) 36.58% compared to head (7c0dab9) 36.60%.

Files	Patch %	Lines
app/components/UI/Bridge/utils/useGoToBridge.ts	66.66%	3 Missing and 2 partials ⚠️
app/components/UI/Bridge/utils/isBridgeAllowed.ts	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7835      +/-   ##
==========================================
+ Coverage   36.58%   36.60%   +0.02%     
==========================================
  Files        1082     1084       +2     
  Lines       29053    29075      +22     
  Branches     2653     2657       +4     
==========================================
+ Hits        10628    10644      +16     
- Misses      17827    17830       +3     
- Partials      598      601       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

app/constants/network.js

app/components/Views/WalletActions/WalletActions.tsx

app/components/UI/Bridge/utils/useGoToBridge.ts

github-actions · 2023-11-21T23:40:46Z

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6d667d93-5bb5-46fd-8293-800e380d1eed
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

github-actions · 2023-11-28T19:31:32Z

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3d2d5350-3db3-4453-aed4-f06f6a8f5ffc
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

## **Description**  Adds translations needed in #7835. ## **Related issues** [METABRIDGE-459](https://consensyssoftware.atlassian.net/browse/METABRIDGE-459) ## **Manual testing steps** 1. Verify that translations are added for each supported language ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [x] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2023-11-29T23:07:13Z

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a49463f4-9bf4-4f76-98ec-7b13bc96b862
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

sonarcloud · 2023-11-30T18:51:16Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

80.0% Coverage
0.0% Duplication

sethkfman

LGTM

BZahory requested a review from a team as a code owner November 15, 2023 20:37

BZahory force-pushed the feat/bridge-button branch 2 times, most recently from 2a505f5 to 76ec629 Compare November 15, 2023 20:59

BZahory force-pushed the feat/bridge-button branch from 76ec629 to d725709 Compare November 20, 2023 22:06

BZahory added the team-bridge label Nov 20, 2023

micaelae reviewed Nov 21, 2023

View reviewed changes

BZahory marked this pull request as draft November 21, 2023 20:55

BZahory changed the title ~~draft: feat: add bridge token+wallet action~~ feat: add bridge token+wallet action Nov 21, 2023

micaelae previously approved these changes Nov 21, 2023

View reviewed changes

BZahory changed the title ~~feat: add bridge token+wallet action~~ feat: add bridge wallet action Nov 21, 2023

BZahory force-pushed the feat/bridge-button branch from e4ee9d5 to ac82a0a Compare November 21, 2023 22:50

BZahory dismissed micaelae’s stale review via 341cd9a November 21, 2023 23:27

BZahory marked this pull request as ready for review November 21, 2023 23:39

github-actions bot added the Run Smoke E2E label Nov 21, 2023

hesterbruikman added the design-review Any feature that needs feedback from the design team label Nov 22, 2023

BZahory force-pushed the feat/bridge-button branch from 341cd9a to 94b533d Compare November 22, 2023 19:34

BZahory marked this pull request as draft November 22, 2023 20:16

BZahory marked this pull request as ready for review November 28, 2023 19:30

BZahory mentioned this pull request Nov 29, 2023

chore: add bridge translations #7952

Merged

13 tasks

BZahory marked this pull request as draft November 29, 2023 22:15

BZahory marked this pull request as ready for review November 29, 2023 23:05

BZahory force-pushed the feat/bridge-button branch from d41a84a to 030c21f Compare November 29, 2023 23:05

BZahory force-pushed the feat/bridge-button branch from 030c21f to 600176d Compare November 30, 2023 04:49

BZahory added 12 commits November 30, 2023 13:39

chore: add bridge networks to network.js

d308a29

chore: create isBridgeAllowed util

df1a717

chore: add Bridge Linked Clicked event

095bb32

chore: export browser params type

14ef7e5

feat: add bridge wallet action

3f71df7

refactor: create bridge navigation hook

278329b

chore: remove redundant chain

45c87d7

fix: do not require slash in regex

65abb56

fix: couple user events with parameters

e525df6

refactor: use selector instead of prop for chain id

06a09ae

docs: add JSDoc comments

049735c

fix: reduce minimum overlay height

7c0dab9

BZahory force-pushed the feat/bridge-button branch from 600176d to 7c0dab9 Compare November 30, 2023 18:39

sethkfman added the release-7.13.0 Issue or pull request that will be included in release 7.13.0 label Nov 30, 2023

sethkfman approved these changes Nov 30, 2023

View reviewed changes

BZahory merged commit c1922b5 into main Nov 30, 2023
28 checks passed

BZahory deleted the feat/bridge-button branch November 30, 2023 18:57

github-actions bot locked and limited conversation to collaborators Nov 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add bridge wallet action #7835

feat: add bridge wallet action #7835

BZahory commented Nov 15, 2023 •

edited

github-actions bot commented Nov 15, 2023 •

edited

BZahory commented Nov 15, 2023

codecov-commenter commented Nov 20, 2023 •

edited

github-actions bot commented Nov 21, 2023

github-actions bot commented Nov 28, 2023

github-actions bot commented Nov 29, 2023

sonarcloud bot commented Nov 30, 2023

sethkfman left a comment

feat: add bridge wallet action #7835

feat: add bridge wallet action #7835

Conversation

BZahory commented Nov 15, 2023 • edited

Description

Motivation

Solution

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

iPhone SE

Happy path flows

Button does not show on unsupported bridge networks

Opening bridge with MetaMask Portfolio, Uniswap, and a non-web3 tab open

Restarting the app with the same tabs open

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Nov 15, 2023 • edited

BZahory commented Nov 15, 2023

codecov-commenter commented Nov 20, 2023 • edited

Codecov Report

github-actions bot commented Nov 21, 2023

github-actions bot commented Nov 28, 2023

github-actions bot commented Nov 29, 2023

sonarcloud bot commented Nov 30, 2023

sethkfman left a comment

Choose a reason for hiding this comment

BZahory commented Nov 15, 2023 •

edited

github-actions bot commented Nov 15, 2023 •

edited

codecov-commenter commented Nov 20, 2023 •

edited