-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: iOS Bitrise yarn setup #7836
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7836 +/- ##
=======================================
Coverage 35.04% 35.04%
=======================================
Files 1040 1040
Lines 27710 27710
Branches 2344 2344
=======================================
Hits 9711 9711
Misses 17475 17475
Partials 524 524 ☔ View full report in Codecov by Sentry. |
This reverts commit 8e50279.
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cf339368-3858-44ec-b6de-0a2626211233 |
Kudos, SonarCloud Quality Gate passed! |
Description
This PR fetches and installs a specific version of node to support the install of yarn. On Mac machines there was not a standard version of node available so we have to fetch and install.
Related issues
Fixes: NA
Manual testing steps
Screenshots/Recordings
Before
Build with successful yarn install ONLY on Android: https://app.bitrise.io/build/344d5061-643e-4ab0-941f-9fc5c63886c4
After
Build with successful yarn install on both platforms: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0cc78e16-09c4-41b8-a012-92f08909f9c5
Pre-merge author checklist
Pre-merge reviewer checklist