Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iOS Bitrise yarn setup #7836

Merged
merged 9 commits into from
Nov 16, 2023
Merged

fix: iOS Bitrise yarn setup #7836

merged 9 commits into from
Nov 16, 2023

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Nov 15, 2023

Description

This PR fetches and installs a specific version of node to support the install of yarn. On Mac machines there was not a standard version of node available so we have to fetch and install.

Related issues

Fixes: NA

Manual testing steps

  1. Run a Bitrise build and see successful yarn install.

Screenshots/Recordings

Before

Build with successful yarn install ONLY on Android: https://app.bitrise.io/build/344d5061-643e-4ab0-941f-9fc5c63886c4

After

Build with successful yarn install on both platforms: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0cc78e16-09c4-41b8-a012-92f08909f9c5

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman added type-bug Something isn't working release-7.12.0 Issue or pull request that will be included in release 7.12.0 labels Nov 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd4a5ad) 35.04% compared to head (10b3151) 35.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7836   +/-   ##
=======================================
  Coverage   35.04%   35.04%           
=======================================
  Files        1040     1040           
  Lines       27710    27710           
  Branches     2344     2344           
=======================================
  Hits         9711     9711           
  Misses      17475    17475           
  Partials      524      524           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cf339368-3858-44ec-b6de-0a2626211233
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

sonarcloud bot commented Nov 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Cal-L Cal-L merged commit 93e2ef8 into main Nov 16, 2023
26 checks passed
@Cal-L Cal-L deleted the fix/ios-bitrise branch November 16, 2023 00:34
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2023
@wachunei
Copy link
Member

I think this does not work
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-mobile-platform type-bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants