Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: microphone and camera on webview #7859

Merged
merged 3 commits into from
Nov 17, 2023
Merged

fix: microphone and camera on webview #7859

merged 3 commits into from
Nov 17, 2023

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Nov 17, 2023

Description

Fix the microphone and camera on webview
The app was crashing when asking for both permissions

Solution is:

Scenario: When dapp/website request just one permission (camera or mic)

  • Should always prompt a dialog asking permission to the user, with the sensor that is being used.

Scenario: When dapp/website request more than one sensor permission

  • Should always prompt a dialog asking permission to the user, with the sensors name that are being used.

The user can always deny access to those sensors everytime a website request it

After accepting the first time User will need to give access to those sensors to be used by MetaMask App.

Related issues

Fixes: #

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

https://recordit.co/Cz75I9YyO6

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-client labels Nov 17, 2023
@tommasini tommasini requested a review from a team as a code owner November 17, 2023 01:18
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ed32a5) 35.31% compared to head (9d7ba37) 35.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7859   +/-   ##
=======================================
  Coverage   35.31%   35.31%           
=======================================
  Files        1040     1040           
  Lines       27718    27718           
  Branches     2339     2339           
=======================================
  Hits         9789     9789           
  Misses      17404    17404           
  Partials      525      525           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tommasini tommasini changed the title fix: microphone on webview fix: microphone and camera on webview Nov 17, 2023
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ac08e15c-e2b2-47ab-808e-a20dbcfa5192
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tommasini tommasini merged commit 3264308 into main Nov 17, 2023
26 checks passed
@tommasini tommasini deleted the fix/mic-on-webview branch November 17, 2023 20:54
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants