-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: microphone and camera on webview #7859
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7859 +/- ##
=======================================
Coverage 35.31% 35.31%
=======================================
Files 1040 1040
Lines 27718 27718
Branches 2339 2339
=======================================
Hits 9789 9789
Misses 17404 17404
Partials 525 525 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ac08e15c-e2b2-47ab-808e-a20dbcfa5192 |
Kudos, SonarCloud Quality Gate passed! |
Description
Fix the microphone and camera on webview
The app was crashing when asking for both permissions
Solution is:
Scenario: When dapp/website request just one permission (camera or mic)
Scenario: When dapp/website request more than one sensor permission
The user can always deny access to those sensors everytime a website request it
After accepting the first time User will need to give access to those sensors to be used by MetaMask App.
Related issues
Fixes: #
Manual testing steps
Screenshots/Recordings
https://recordit.co/Cz75I9YyO6
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist