Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Updated Toast story #7860

Merged
merged 1 commit into from
Nov 17, 2023
Merged

refactor: Updated Toast story #7860

merged 1 commit into from
Nov 17, 2023

Conversation

brianacnguyen
Copy link
Contributor

Description

  • Updated Toast story to new format

Screenshots/Recordings

Simulator Screen Shot - iPhone 14 Pro - 2023-11-16 at 21 04 11
Simulator Screen Shot - iPhone 14 Pro - 2023-11-16 at 21 04 15
Simulator Screen Shot - iPhone 14 Pro - 2023-11-16 at 21 04 19

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile labels Nov 17, 2023
@brianacnguyen brianacnguyen self-assigned this Nov 17, 2023
@brianacnguyen brianacnguyen requested a review from a team as a code owner November 17, 2023 05:06
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 17, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (eeb99d8) 35.17% compared to head (3cfa40d) 35.16%.

Files Patch % Lines
...mponent-library/components/Toast/Toast.stories.tsx 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7860      +/-   ##
==========================================
- Coverage   35.17%   35.16%   -0.01%     
==========================================
  Files        1039     1039              
  Lines       27614    27619       +5     
  Branches     2340     2341       +1     
==========================================
  Hits         9712     9712              
- Misses      17377    17382       +5     
  Partials      525      525              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@georgewrmarshall georgewrmarshall merged commit 5516de3 into main Nov 17, 2023
35 checks passed
@georgewrmarshall georgewrmarshall deleted the morph/convert-toast branch November 17, 2023 21:08
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 17, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants