-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable Blockaid on iOS #7861
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d0dc9670-607e-44dd-b33a-05cf97b05491 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7861 +/- ##
=======================================
Coverage 37.42% 37.42%
=======================================
Files 1052 1052
Lines 28176 28176
Branches 2516 2517 +1
=======================================
Hits 10544 10544
Misses 17033 17033
Partials 599 599 ☔ View full report in Codecov by Sentry. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3e18fd8a-f30b-4249-97db-d0935cb75c8a |
Kudos, SonarCloud Quality Gate passed! |
Tested on iOS: https://recordit.co/FYtYctqwqt |
Screen.Recording.2023-11-21.at.12.56.57.AM.movBlockaid is not enabled on android, blockaid banner not visible on transaction page nor blockaid setting is visible in experimental settings. |
Description
Change in build file to enable blockaid in IOS build
Related issues
Fixes: #1353
Manual testing steps
NA
Screenshots/Recordings
NA
Pre-merge author checklist
Pre-merge reviewer checklist