Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable Blockaid on iOS #7861

Merged
merged 7 commits into from
Nov 21, 2023
Merged

feat: enable Blockaid on iOS #7861

merged 7 commits into from
Nov 21, 2023

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Nov 17, 2023

Description

Change in build file to enable blockaid in IOS build

Related issues

Fixes: #1353

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team labels Nov 17, 2023
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d0dc9670-607e-44dd-b33a-05cf97b05491
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (da3d7fc) 37.42% compared to head (2e45ad5) 37.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7861   +/-   ##
=======================================
  Coverage   37.42%   37.42%           
=======================================
  Files        1052     1052           
  Lines       28176    28176           
  Branches     2516     2517    +1     
=======================================
  Hits        10544    10544           
  Misses      17033    17033           
  Partials      599      599           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

scripts/build.sh Outdated Show resolved Hide resolved
scripts/build.sh Outdated Show resolved Hide resolved
@jpuri jpuri marked this pull request as ready for review November 20, 2023 06:43
@jpuri jpuri requested a review from a team as a code owner November 20, 2023 06:43
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3e18fd8a-f30b-4249-97db-d0935cb75c8a
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

sonarcloud bot commented Nov 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@blackdevelopa
Copy link
Contributor

Tested on iOS: https://recordit.co/FYtYctqwqt

@jpuri
Copy link
Contributor Author

jpuri commented Nov 20, 2023

Screen.Recording.2023-11-21.at.12.56.57.AM.mov

Blockaid is not enabled on android, blockaid banner not visible on transaction page nor blockaid setting is visible in experimental settings.

@sethkfman sethkfman changed the title Change in build file to enable blockaid in IOS build feat: enable Blockaid on iOS Nov 20, 2023
@sethkfman
Copy link
Contributor

@jpuri jpuri merged commit c31cd25 into main Nov 21, 2023
28 checks passed
@jpuri jpuri deleted the blockaid_build_change branch November 21, 2023 10:03
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 21, 2023
@metamaskbot metamaskbot added the release-7.13.0 Issue or pull request that will be included in release 7.13.0 label Nov 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.13.0 Issue or pull request that will be included in release 7.13.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View my transaction history
7 participants