Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ramp): sell what's new modal content #7864

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Nov 17, 2023

Description

This PR adds What's New modal content for sell feature.

TO DO:

Related issues

Fixes: #

Manual testing steps

  1. What's new modal must show sell feature content. Blockaid content must display conditionally according to feature flag

Screenshots/Recordings

Before

After

Without Blockaid Content

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-11-17.at.12.12.29.mp4

With Blockaid Content

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-11-17.at.12.12.56.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features labels Nov 17, 2023
@wachunei wachunei changed the title feat(ramp): sell what's new content feat(ramp): sell what's new modal content Nov 17, 2023
georgeweiler
georgeweiler previously approved these changes Nov 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

Attention: 297 lines in your changes are missing coverage. Please review.

Comparison is base (5516de3) 35.31% compared to head (080d677) 37.42%.
Report is 1 commits behind head on main.

Files Patch % Lines
...ents/UI/Ramp/buy/hooks/useHandleSuccessfulOrder.ts 0.00% 40 Missing ⚠️
app/components/UI/Ramp/index.tsx 0.00% 24 Missing ⚠️
app/components/UI/Ramp/common/hooks/useBalance.ts 0.00% 21 Missing ⚠️
.../components/UI/Ramp/buy/hooks/useFiatCurrencies.ts 0.00% 19 Missing ⚠️
...omponents/UI/Ramp/buy/hooks/useCryptoCurrencies.ts 0.00% 18 Missing ⚠️
...nents/UI/Ramp/common/hooks/useFetchRampNetworks.ts 0.00% 16 Missing ⚠️
...ents/UI/Ramp/common/hooks/useRampNetworksDetail.ts 0.00% 15 Missing ⚠️
app/components/UI/Ramp/common/sdk/index.tsx 22.22% 14 Missing ⚠️
app/components/UI/Ramp/buy/hooks/useLimits.ts 9.09% 10 Missing ⚠️
app/components/UI/Ramp/buy/Views/Quotes/Quotes.tsx 81.63% 2 Missing and 7 partials ⚠️
... and 34 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7864      +/-   ##
==========================================
+ Coverage   35.31%   37.42%   +2.11%     
==========================================
  Files        1040     1052      +12     
  Lines       27723    28177     +454     
  Branches     2340     2516     +176     
==========================================
+ Hits         9789    10544     +755     
+ Misses      17409    17034     -375     
- Partials      525      599      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wachunei wachunei marked this pull request as ready for review November 17, 2023 22:06
@wachunei wachunei requested a review from a team as a code owner November 17, 2023 22:06
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/734c7f4c-ace1-41ac-8e29-71b548aa539f
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@wachunei wachunei added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Nov 17, 2023
@sethkfman sethkfman added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 17, 2023
@wachunei wachunei added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 20, 2023
@wachunei wachunei merged commit 4e01d6e into main Nov 20, 2023
31 of 34 checks passed
@wachunei wachunei deleted the feat/ramp-sell-whats-new-modal branch November 20, 2023 18:39
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
@metamaskbot metamaskbot added the release-7.13.0 Issue or pull request that will be included in release 7.13.0 label Nov 20, 2023
@gauthierpetetin gauthierpetetin removed the release-7.13.0 Issue or pull request that will be included in release 7.13.0 label Jan 2, 2024
@metamaskbot
Copy link
Collaborator

More than one release label on PR. Keeping the lowest one (release-7.12.0) on PR and removing other release labels (release-7.13.0).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.12.0 Issue or pull request that will be included in release 7.12.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants