Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display the dapp icon when connecting with sdk #7876

Merged
merged 2 commits into from
Nov 22, 2023
Merged

feat: display the dapp icon when connecting with sdk #7876

merged 2 commits into from
Nov 22, 2023

Conversation

omridan159
Copy link
Contributor

@omridan159 omridan159 commented Nov 20, 2023 •
edited

Description

Display the Dapp icon when connecting with SDK on all the relevant modals

Related issues

Fixes: #

Manual testing steps

  1. Ensured that the icon is displayed correctly in all possible cases.

Screenshots/Recordings

Before

After

283124652-e5b14258-e654-4d5f-8b6d-785a70f4e839.mov
Screenshot 2023-11-20 at 11 20 15

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@omridan159 omridan159 requested a review from a team as a code owner November 20, 2023 09:26
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@omridan159 omridan159 added the team-sdk SDK team label Nov 20, 2023
abretonc7s
abretonc7s previously approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@abretonc7s abretonc7s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/49d18135-351a-4c9a-a6b6-2a1b3d771862
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

70.0% 70.0% Coverage
0.0% 0.0% Duplication

@christopherferreira9 christopherferreira9 added needs-qa Any New Features that needs a full manual QA prior to being added to a release. QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 20, 2023
@christopherferreira9
Copy link
Contributor

Generic steps:

  • Connect to the dapp -> See icon in the top of the modal
  • Sign -> See icon in the top of the modal
  • SendTransaction -> See icon in the top of the modal

TC 1:

  • Set iconUrl in the SDK dapp metadata -> You should see this icon being loaded on the mobile side

TC 2:

  • Set base64 in the SDK dapp metadata -> You should see this icon being loaded on the mobile side

TC 3:

  • Set a huge base64 in the SDK dapp metadata -> Wallet defaults to use the Initial of the Dapp name as an icon

TC 4:

  • Set a non existing iconUrl in the SDK dapp metadata -> Wallet defaults to use the Initial of the Dapp name as an icon

@christopherferreira9
Copy link
Contributor

TC1:

Screen.Recording.2023-11-21.at.17.08.02.mov

TC2:

Screen.Recording.2023-11-21.at.17.27.27.mov

TC3/TC4 (simulates the base64 being too big and url returning 404 since it comes from the SDK side) :

Screen.Recording.2023-11-21.at.17.35.29.mov

@christopherferreira9 christopherferreira9 added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Nov 22, 2023
@christopherferreira9 christopherferreira9 merged commit 756209b into main Nov 22, 2023
33 of 34 checks passed
@christopherferreira9 christopherferreira9 deleted the feat_display-the-dapp-icon-when-connecting-with-sdk branch November 22, 2023 10:24
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2023
@metamaskbot metamaskbot added the release-7.13.0 Issue or pull request that will be included in release 7.13.0 label Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abretonc7s abretonc7s abretonc7s approved these changes

Assignees

@abretonc7s abretonc7s

Labels
QA Passed A successful QA run through has been done release-7.13.0 Issue or pull request that will be included in release 7.13.0 team-sdk SDK team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@omridan159 @christopherferreira9 @abretonc7s @metamaskbot