Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Settings Security And Privacy: Refactor page objects #7888

Merged
merged 25 commits into from
Dec 4, 2023

Conversation

SamuelSalas
Copy link
Member

@SamuelSalas SamuelSalas commented Nov 21, 2023

Description

Add Page object model to Security and privacy pages

Related issues

Fixes: #1331

Manual testing steps

Screenshots/Recordings

Regression test results: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c2e6abe4-ebd0-47bf-b2d3-e7e0f71cd8a8
Smoke test results: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/aaab857b-bd2f-4a99-beb5-7c7b474749f3

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@SamuelSalas SamuelSalas self-assigned this Nov 21, 2023
@SamuelSalas SamuelSalas requested a review from a team as a code owner November 21, 2023 01:15
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2023

Codecov Report

Attention: 157 lines in your changes are missing coverage. Please review.

Comparison is base (199aa40) 36.60% compared to head (b08f8ef) 36.60%.
Report is 4 commits behind head on main.

Files Patch % Lines
app/store/migrations/004.js 0.00% 30 Missing ⚠️
app/store/migrations/007.js 0.00% 18 Missing ⚠️
app/store/migrations/008.js 0.00% 17 Missing ⚠️
app/store/migrations/003.js 0.00% 11 Missing ⚠️
app/store/migrations/013.js 0.00% 11 Missing ⚠️
app/store/migrations/001.js 0.00% 8 Missing ⚠️
app/store/migrations/012.js 0.00% 8 Missing ⚠️
app/store/migrations/000.js 0.00% 7 Missing ⚠️
app/store/migrations/002.js 0.00% 7 Missing ⚠️
app/store/migrations/005.js 0.00% 4 Missing ⚠️
... and 13 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7888   +/-   ##
=======================================
  Coverage   36.60%   36.60%           
=======================================
  Files        1092     1120   +28     
  Lines       29178    29178           
  Branches     2677     2678    +1     
=======================================
  Hits        10681    10681           
  Misses      17885    17885           
  Partials      612      612           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelSalas SamuelSalas marked this pull request as ready for review November 24, 2023 20:40
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a046ba57-8d0e-48fe-adaf-bd6fc31e9421
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d616bb68-75af-4500-99ac-59426ad96a23
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@metamaskbot metamaskbot added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed ready-for-dev labels Nov 24, 2023
@metamaskbot metamaskbot added in-progress and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Nov 28, 2023
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments @SamuelSalas

e2e/specs/quarantine/deeplinks.failing.js Outdated Show resolved Hide resolved
e2e/specs/quarantine/deeplinks.failing.js Outdated Show resolved Hide resolved
e2e/specs/settings/delete-wallet.spec.js Outdated Show resolved Hide resolved
e2e/utils/Gestures.js Outdated Show resolved Hide resolved
e2e/specs/onboarding/onboarding-wizard-opt-in.spec.js Outdated Show resolved Hide resolved
e2e/specs/quarantine/contract-nickname.failing.js Outdated Show resolved Hide resolved
e2e/specs/quarantine/contract-nickname.failing.js Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Dec 1, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/aaab857b-bd2f-4a99-beb5-7c7b474749f3
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

cortisiko
cortisiko previously approved these changes Dec 1, 2023
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good. TY @SamuelSalas

Copy link
Contributor

github-actions bot commented Dec 1, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c17e440e-b0a8-43b4-addf-6c70c278d23a
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

sonarcloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SamuelSalas SamuelSalas merged commit 53c7f86 into main Dec 4, 2023
26 checks passed
@SamuelSalas SamuelSalas deleted the test/1331-security-privacy-refactor-page-objects branch December 4, 2023 17:12
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
@metamaskbot metamaskbot added the release-7.14.0 Issue or pull request that will be included in release 7.14.0 label Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.14.0 Issue or pull request that will be included in release 7.14.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1 milestone planning
6 participants