-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Settings Security And Privacy: Refactor page objects #7888
test: Settings Security And Privacy: Refactor page objects #7888
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7888 +/- ##
=======================================
Coverage 36.60% 36.60%
=======================================
Files 1092 1120 +28
Lines 29178 29178
Branches 2677 2678 +1
=======================================
Hits 10681 10681
Misses 17885 17885
Partials 612 612 ☔ View full report in Codecov by Sentry. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a046ba57-8d0e-48fe-adaf-bd6fc31e9421 |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d616bb68-75af-4500-99ac-59426ad96a23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments @SamuelSalas
e2e/pages/Drawer/Settings/SecurityAndPrivacy/ChangePasswordView.js
Outdated
Show resolved
Hide resolved
e2e/specs/permission-systems/permission-system-delete-wallet.spec.js
Outdated
Show resolved
Hide resolved
e2e/pages/Drawer/Settings/SecurityAndPrivacy/RevealSecretRecoveryPhrase.js
Outdated
Show resolved
Hide resolved
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/aaab857b-bd2f-4a99-beb5-7c7b474749f3 |
app/components/Views/Settings/SecuritySettings/SecuritySettings.test.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good. TY @SamuelSalas
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c17e440e-b0a8-43b4-addf-6c70c278d23a |
Kudos, SonarCloud Quality Gate passed!
|
Description
Add Page object model to Security and privacy pages
Related issues
Fixes: #1331
Manual testing steps
Screenshots/Recordings
Regression test results: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c2e6abe4-ebd0-47bf-b2d3-e7e0f71cd8a8
Smoke test results: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/aaab857b-bd2f-4a99-beb5-7c7b474749f3
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist