-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ramp): popular region and search states #7899
Conversation
1a263c8
to
8fb89f6
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7899 +/- ##
==========================================
- Coverage 37.46% 37.45% -0.02%
==========================================
Files 1052 1052
Lines 28202 28224 +22
Branches 2517 2524 +7
==========================================
+ Hits 10566 10571 +5
- Misses 17037 17048 +11
- Partials 599 605 +6 ☔ View full report in Codecov by Sentry. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1a7b02be-03d2-420a-af67-734adf8ed4e9 |
@wachunei LGTM I verified this change for regions ✅ |
@bkirb can you quickly verify again? by self reviewing I found an issue and I added a fix to avoid recomputing the fuzzy search engine on every keystroke |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@wachunei LGTM I verified with the latest changes ✅ |
Description
This PR improves the Region selector for Ramp flows by removing duplicate code and adding these features:
Related issues
Fixes: #
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist