-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: tranfer the DeeplinkManager file from JS to TS #7908
chore: tranfer the DeeplinkManager file from JS to TS #7908
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…nkManager-file-from-JS-to-TS
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7908 +/- ##
==========================================
- Coverage 36.60% 36.60% -0.01%
==========================================
Files 1092 1092
Lines 29178 29180 +2
Branches 2678 2715 +37
==========================================
- Hits 10681 10680 -1
- Misses 17885 17888 +3
Partials 612 612 ☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! |
Checked for both Android and iOS
|
E2E run: https://app.bitrise.io/build/8a6080b9-9230-48a7-8957-03f37e3fb794 |
Description
Transfer the DeeplinkManager.js file from JS to TS to have type safety.
Related issues
Fixes: #
Manual testing steps
devnext
project on a testing device.devreactnative
project on a testing device.Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist