Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tranfer the DeeplinkManager file from JS to TS #7908

Merged

Conversation

omridan159
Copy link
Contributor

@omridan159 omridan159 commented Nov 23, 2023

Description

Transfer the DeeplinkManager.js file from JS to TS to have type safety.

Related issues

Fixes: #

Manual testing steps

  1. Test the deep links behavior with the devnext project on a testing device.
  2. Test the deep links behavior with the devreactnative project on a testing device.

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@omridan159 omridan159 requested a review from a team as a code owner November 23, 2023 09:48
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

abretonc7s
abretonc7s previously approved these changes Nov 23, 2023
Copy link
Contributor

@abretonc7s abretonc7s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherferreira9 christopherferreira9 self-assigned this Nov 23, 2023
@christopherferreira9 christopherferreira9 added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Nov 23, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (eb52137) 36.60% compared to head (29c294b) 36.60%.

Files Patch % Lines
app/core/DeeplinkManager.ts 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7908      +/-   ##
==========================================
- Coverage   36.60%   36.60%   -0.01%     
==========================================
  Files        1092     1092              
  Lines       29178    29180       +2     
  Branches     2678     2715      +37     
==========================================
- Hits        10681    10680       -1     
- Misses      17885    17888       +3     
  Partials      612      612              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.4% 0.4% Coverage
0.0% 0.0% Duplication

@christopherferreira9
Copy link
Contributor

Checked for both Android and iOS

@christopherferreira9
Copy link
Contributor

E2E run: https://app.bitrise.io/build/8a6080b9-9230-48a7-8957-03f37e3fb794
The failing tests are not related to this refactor

@christopherferreira9 christopherferreira9 merged commit 7338dfb into main Dec 4, 2023
25 of 26 checks passed
@christopherferreira9 christopherferreira9 deleted the chore_transfer-DeeplinkManager-file-from-JS-to-TS branch December 4, 2023 16:19
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
@github-actions github-actions bot removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Dec 4, 2023
@metamaskbot metamaskbot added the release-7.14.0 Issue or pull request that will be included in release 7.14.0 label Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.14.0 Issue or pull request that will be included in release 7.14.0 team-sdk SDK team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants