chore(patch): Use core branch for assets-controllers patch #7922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
added
No QA Needed/E2E Only
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7922 +/- ##
=======================================
Coverage 37.39% 37.39%
=======================================
Files 1052 1052
Lines 28175 28175
Branches 2517 2517
=======================================
Hits 10536 10536
Misses 17040 17040
Partials 599 599 ☔ View full report in Codecov by Sentry. |
|
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/76ffd11c-5ce6-4ec7-8fa6-a7008ec9a2a1 |
Gudahtt
force-pushed
the
update-token-rates-controller-patch
branch
from
e6df9f9
to
7c8405d
Compare
The `@metamask/assets-controllers` patch for the TokenRatesController has been updated to use a branch on the core monorepo. Using a core branch for these patch changes lets us more easily lint and type check the changes (and even test them if we feel the need), and avoids the need to work with compiled JavaScript (which can be tricky, especially when dealing with async code). The patch is functionally identical to before; the only differences are type fixes, and a comment explaining the patch and how it is maintained. So far only the `TokenRatesController` portion of the patch uses this branch, but we can extend this strategy later to the other files in this patch, if we find that useful. Relates to #7903
Gudahtt
force-pushed
the
update-token-rates-controller-patch
branch
from
7c8405d
to
210f858
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
metamaskbot
added
the
release-7.13.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
@metamask/assets-controllerspatch for the TokenRatesController has been updated to use a branch on the core monorepo. Using a core branch for these patch changes lets us more easily lint and type check the changes (and even test them if we feel the need), and avoids the need to work with compiled JavaScript (which can be tricky, especially when dealing with async code).The patch is functionally identical to before; the only differences are type fixes, and a comment explaining the patch and how it is maintained.
So far only the
TokenRatesControllerportion of the patch uses this branch, but we can extend this strategy later to the other files in this patch, if we find that useful.Related issues
Relates to #7903
Manual testing steps
N/A, no functional changes
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist