-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor the DeeplinkManager into smaller parts and add unit tests #7925
chore: refactor the DeeplinkManager into smaller parts and add unit tests #7925
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should rename all the handleParseMetamask/Universal/Walle by handleMetamask/Univer/Walle.
It would make it easier to match the filename to the functionality without opening the file
…nkManager-file-from-JS-to-TS
… chore_split-DeeplinkManager-class-into-smaller-chunks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The base branch was changed.
Checked for both Android and iOS
Only one issue found @omridan159 .
Video: Screen.Recording.2023-12-04.at.17.45.23.mov |
…anager-class-into-smaller-chunks
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The issue mentioned above is fixed. |
Description
Refactored the
DeeplinkManager
class into smaller, more manageable components, enhancing code readability and maintainability.This change simplifies future modifications and debugging. Additionally, comprehensive unit tests were added to ensure each component functions correctly, boosting overall software reliability.
Related issues
Fixes: #
Manual testing steps
IOS
devnext
project on a testing device.devreactnative
project on a testing device.Android:
devnext
project on a testing device.devreactnative
project on a testing device.Screenshots/Recordings
Before
After
Screen.Recording.2023-11-24.at.11.00.23.mov
Pre-merge author checklist
Pre-merge reviewer checklist