Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Increase E2E test setup time #7929

Merged
merged 2 commits into from
Nov 26, 2023
Merged

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented Nov 26, 2023

Description

The android E2E tests have encountered failures because the installation of the application on the emulator now takes longer than the current test timeout allows. In order to restore the ability to pass the E2E tests, the purpose of this pull request (PR) is to increase the test setup time, allowing sufficient time for the installation process.

Before

Failing Bitrise builds:
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fa0431b0-3114-4a0f-a511-23d065d4d244
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/10be074e-af5f-4750-8d72-7e61c6102b9d
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fa0431b0-3114-4a0f-a511-23d065d4d244

After

Passing bitrise smoke Build: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/354f2ad1-121b-4f48-9d7d-479bcb00160d
Passing bitrise regression test build: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/354f2ad1-121b-4f48-9d7d-479bcb00160d

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ba70c4) 37.44% compared to head (cee468d) 37.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7929   +/-   ##
=======================================
  Coverage   37.44%   37.44%           
=======================================
  Files        1052     1052           
  Lines       28192    28192           
  Branches     2517     2517           
=======================================
  Hits        10556    10556           
  Misses      17037    17037           
  Partials      599      599           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cortisiko cortisiko added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. team-mobile-client E2E labels Nov 26, 2023
@cortisiko cortisiko marked this pull request as ready for review November 26, 2023 16:38
@cortisiko cortisiko requested a review from a team as a code owner November 26, 2023 16:38
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 26, 2023
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c44cdbc9-8334-490a-bdb4-1c7f59e3a115
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@cortisiko cortisiko merged commit 2027dcf into main Nov 26, 2023
44 of 45 checks passed
@cortisiko cortisiko deleted the detox/increase-setup-time branch November 26, 2023 17:05
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2023
@metamaskbot metamaskbot added the release-7.13.0 Issue or pull request that will be included in release 7.13.0 label Nov 26, 2023
@gauthierpetetin gauthierpetetin added release-7.12.4 and removed release-7.13.0 Issue or pull request that will be included in release 7.13.0 labels Jan 2, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-7.12.4 on PR. Adding release label release-7.12.4 on PR and removing other release labels(release-7.13.0), as PR was added to branch 7.12.4 when release was cut.

@metamaskbot
Copy link
Collaborator

Missing release label release-7.12.3 on PR. Adding release label release-7.12.3 on PR and removing other release labels(release-7.13.0), as PR was added to branch 7.12.3 when release was cut.

@metamaskbot
Copy link
Collaborator

More than one release label on PR. Keeping the lowest one (release-7.12.3) on PR and removing other release labels (release-7.12.4).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E2E INVALID-PR-TEMPLATE PR's body doesn't match template No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.12.3 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants