Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updating CODEOWNERS file with DS ownership of component-library #7937

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

georgewrmarshall
Copy link
Contributor

@georgewrmarshall georgewrmarshall commented Nov 28, 2023

Description

This PR modifies the .github/CODEOWNERS file to assign the @MetaMask/design-system-engineers team as the code owners of the app/component-library directory.

Upon the successful merge of this PR, any modifications made to the files within the app/component-library directory will necessitate a review from the @MetaMask/design-system-engineers team. This ensures that the team has oversight on all changes to these specific files, enhancing the quality and consistency of our UI components.

Considering the approximate monthly updates made by contributors outside of the design system team, we believe the volume is manageable. Here's a breakdown of the past few months:

  • November: 5 updates
  • October: 1 update
  • September: 4 updates
  • August: 4 updates
  • July: 5 updates

Need a review?

The below details are in the description of the @MetaMask/design-system-engineers but if you came across this PR and need a review

  • tag us in slack: @metamask-design-system-team
  • or post in the slack channel: #metamask-design-system

Related issues

Fixes: #7936

Screenshots/Recordings

N/A

Manual testing steps

  1. Check .github/CODEOWNERS folder path for app/component-library and @MetaMask/design-system-engineers is correct

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@georgewrmarshall georgewrmarshall requested a review from a team as a code owner November 28, 2023 18:37
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall self-assigned this Nov 28, 2023
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Mobile label Nov 28, 2023
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 28, 2023
@georgewrmarshall georgewrmarshall changed the title Updating CODEOWNERS file with component library DS ownership chore: Updating CODEOWNERS file with component library DS ownership Nov 28, 2023
@georgewrmarshall georgewrmarshall changed the title chore: Updating CODEOWNERS file with component library DS ownership chore: Updating CODEOWNERS file with DS ownership of component-library Nov 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b58f4f6) 37.44% compared to head (d45e6e1) 37.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7937   +/-   ##
=======================================
  Coverage   37.44%   37.44%           
=======================================
  Files        1052     1052           
  Lines       28192    28192           
  Branches     2517     2517           
=======================================
  Hits        10556    10556           
  Misses      17037    17037           
  Partials      599      599           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@metamaskbot metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 28, 2023
@brianacnguyen brianacnguyen merged commit e9a05ee into main Nov 29, 2023
38 of 39 checks passed
@brianacnguyen brianacnguyen deleted the fix/7936/ds-code-owners branch November 29, 2023 21:20
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2023
@metamaskbot metamaskbot added the release-7.13.0 Issue or pull request that will be included in release 7.13.0 label Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.13.0 Issue or pull request that will be included in release 7.13.0 team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update codeowners with design system folder
4 participants