Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added SelectButton #7938

Merged
merged 13 commits into from
Dec 19, 2023
Merged

feat: Added SelectButton #7938

merged 13 commits into from
Dec 19, 2023

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Nov 28, 2023

Description

  • Added new components SelectButton

Screenshots/Recordings

Simulator Screen Shot - iPhone 14 Pro - 2023-11-28 at 10 57 54
Simulator Screen Shot - iPhone 14 Pro - 2023-11-28 at 10 58 01

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile labels Nov 28, 2023
@brianacnguyen brianacnguyen self-assigned this Nov 28, 2023
@brianacnguyen brianacnguyen requested a review from a team as a code owner November 28, 2023 19:00
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 28, 2023
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we break this PR down further? As of writing this comment it's 1,408 code changes which is on the large side. Also a video rather than long images I think would really improve the PR description and help QA this PR

@brianacnguyen brianacnguyen requested a review from a team as a code owner December 1, 2023 00:01
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (9884203) 39.39% compared to head (493edec) 39.44%.
Report is 2 commits behind head on main.

Files Patch % Lines
...ponents/Select/SelectButton/SelectButton.styles.ts 35.00% 9 Missing and 4 partials ⚠️
...ry/components/Select/SelectButton/SelectButton.tsx 50.00% 5 Missing and 3 partials ⚠️
...nents/Select/SelectButton/SelectButton.stories.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7938      +/-   ##
==========================================
+ Coverage   39.39%   39.44%   +0.05%     
==========================================
  Files        1220     1227       +7     
  Lines       29800    29861      +61     
  Branches     2831     2843      +12     
==========================================
+ Hits        11740    11779      +39     
- Misses      17371    17387      +16     
- Partials      689      695       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianacnguyen brianacnguyen changed the title feat: Added SelectButton and SelectValue feat: Added SelectButton Dec 1, 2023
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Left a few suggestions

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few non blocking suggestions. Still looks like the PR template hasn't been filled out adequately and missing the checklist.

Co-authored-by: George Marshall <george.marshall@consensys.net>
brianacnguyen and others added 4 commits December 14, 2023 19:38
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: George Marshall <george.marshall@consensys.net>
…ton.tsx

Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: George Marshall <george.marshall@consensys.net>
Copy link

sonarcloud bot commented Dec 15, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
64.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Dec 15, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
64.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good however, there doesn't seem to be adequate testing coverage for this component? You are not testing all of the sizes, isDisabled, isDanger props

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing as other mobile components have very light testing coverage and there are no official testing coverage criteria I can approve but we should discuss in the NY

@brianacnguyen brianacnguyen merged commit 2fbadc3 into main Dec 19, 2023
26 checks passed
@brianacnguyen brianacnguyen deleted the morph/select-button branch December 19, 2023 04:43
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 19, 2023
@metamaskbot metamaskbot added the release-7.15.0 Issue or pull request that will be included in release 7.15.0 label Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-7.15.0 Issue or pull request that will be included in release 7.15.0 team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants