Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: minor changes to connect QR wallet screen #7954

Merged
merged 5 commits into from
Dec 6, 2023
Merged

feat: minor changes to connect QR wallet screen #7954

merged 5 commits into from
Dec 6, 2023

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Nov 29, 2023 •
edited

Description

This PR introduces minor UI improvements to the Connect QR wallet screen

Related issues

Fixes: #7002

Manual testing steps

  1. Go to "Add account or hardware wallet" > "Add hardware wallet" > "QR wallet"
  2. Verify the UI changes

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gantunesr gantunesr requested a review from a team as a code owner November 29, 2023 20:14
@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-accounts labels Nov 29, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@gantunesr gantunesr added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Dec 6, 2023
@gantunesr gantunesr merged commit fc59bb5 into main Dec 6, 2023
29 checks passed
@gantunesr gantunesr deleted the feat/ui-changes-connect-qr branch December 6, 2023 23:10
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2023
@metamaskbot metamaskbot added the release-7.14.0 Issue or pull request that will be included in release 7.14.0 label Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@owencraston owencraston owencraston approved these changes

Assignees
No one assigned
Labels
release-7.14.0 Issue or pull request that will be included in release 7.14.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-accounts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keystone logo update
3 participants
@gantunesr @owencraston @metamaskbot