Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ramp): add sell order polling when has txhash #7963

Merged
merged 6 commits into from
Dec 5, 2023

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Nov 30, 2023

Description

This PR adds a polling to update sell orders that are status CREATED and the user has sent a transaction (ie, the order has a sellTxHash property), while the user is at that screen only. This will help the user get the order updated since the main order polling system does not poll for CREATED order.

Related issues

Fixes: #

Manual testing steps

  1. Go through the Sell flow and finish it
  2. Go send a transaction and wait for the order to update from "Pending" (status = CREATED) to "Processing" (status= PENDING)

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features needs-ramp-qa Tickets that need feature QA on the ramps flows labels Nov 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (89eb8cd) 36.59% compared to head (b7c4fd0) 36.61%.

Files Patch % Lines
...UI/Ramp/common/Views/OrderDetails/OrderDetails.tsx 89.47% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7963      +/-   ##
==========================================
+ Coverage   36.59%   36.61%   +0.02%     
==========================================
  Files        1120     1120              
  Lines       29188    29196       +8     
  Branches     2717     2720       +3     
==========================================
+ Hits        10682    10691       +9     
+ Misses      17894    17893       -1     
  Partials      612      612              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wachunei wachunei marked this pull request as ready for review November 30, 2023 19:45
@wachunei wachunei requested a review from a team as a code owner November 30, 2023 19:45
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/02950f7b-e372-4d8c-9573-7335171585e8
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@bkirb
Copy link
Contributor

bkirb commented Dec 4, 2023

@wachunei LGTM I verified the redirection and polling ✅

@wachunei wachunei added ramp-qa-passed and removed needs-ramp-qa Tickets that need feature QA on the ramps flows labels Dec 5, 2023
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 5, 2023
Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@wachunei wachunei merged commit cbaa4bc into main Dec 5, 2023
24 checks passed
@wachunei wachunei deleted the feat/ramp-created-sell-polling branch December 5, 2023 18:16
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
@metamaskbot metamaskbot added the release-7.14.0 Issue or pull request that will be included in release 7.14.0 label Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ramp-qa-passed release-7.14.0 Issue or pull request that will be included in release 7.14.0 team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants