-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ramp): add sell order polling when has txhash #7963
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7963 +/- ##
==========================================
+ Coverage 36.59% 36.61% +0.02%
==========================================
Files 1120 1120
Lines 29188 29196 +8
Branches 2717 2720 +3
==========================================
+ Hits 10682 10691 +9
+ Misses 17894 17893 -1
Partials 612 612 ☔ View full report in Codecov by Sentry. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/02950f7b-e372-4d8c-9573-7335171585e8 |
@wachunei LGTM I verified the redirection and polling ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Kudos, SonarCloud Quality Gate passed! |
Description
This PR adds a polling to update sell orders that are status
CREATED
and the user has sent a transaction (ie, the order has asellTxHash
property), while the user is at that screen only. This will help the user get the order updated since the main order polling system does not poll forCREATED
order.Related issues
Fixes: #
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist