Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Created SelectOption #7969

Merged
merged 9 commits into from
Dec 19, 2023
Merged

feat: Created SelectOption #7969

merged 9 commits into from
Dec 19, 2023

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Dec 1, 2023

Description

  • Added SelectOption

Related issues

Manual testing steps

  1. Change pointer to storybook
  2. Navigate to SelectOption

Screenshots/Recordings

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-11-30.at.16.23.17.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile labels Dec 1, 2023
@brianacnguyen brianacnguyen self-assigned this Dec 1, 2023
@brianacnguyen brianacnguyen requested review from a team as code owners December 1, 2023 00:26
Copy link
Contributor

github-actions bot commented Dec 1, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2fbadc3) 39.46% compared to head (663622d) 39.47%.
Report is 1 commits behind head on main.

Files Patch % Lines
...nents/Select/SelectOption/SelectOption.stories.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7969      +/-   ##
==========================================
+ Coverage   39.46%   39.47%   +0.01%     
==========================================
  Files        1227     1231       +4     
  Lines       29796    29808      +12     
  Branches     2833     2834       +1     
==========================================
+ Hits        11759    11768       +9     
- Misses      17345    17348       +3     
  Partials      692      692              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Left some minor non-blocking comments.

  • Checked code
  • Checked documentation links, spelling and gramma
  • Did not check running in simulator

Make sure you fill out the PR description properly you are missing:

  • Manual testing steps
  • Link to the related issue
  • Checkboxes
    PR descriptions greatly help with review and have massive pay offs in future when looking back on work and decisions made in the code base

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you have some failing tests but code LGMT. Remember to fill out the PR description so we can understand what this PR contains in future

Co-authored-by: George Marshall <george.marshall@consensys.net>
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but you haven't filled out the PR template

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fill out PR template otherwise LGTM

Copy link

sonarcloud bot commented Dec 19, 2023

@brianacnguyen brianacnguyen merged commit 2c0cdb6 into main Dec 19, 2023
28 checks passed
@brianacnguyen brianacnguyen deleted the morph/select-option branch December 19, 2023 16:55
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 19, 2023
@metamaskbot metamaskbot added the release-7.15.0 Issue or pull request that will be included in release 7.15.0 label Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.15.0 Issue or pull request that will be included in release 7.15.0 team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants