Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updated ButtonLink to use text when size is auto #7971

Merged
merged 2 commits into from
Dec 1, 2023
Merged

fix: Updated ButtonLink to use text when size is auto #7971

merged 2 commits into from
Dec 1, 2023
+60 −67

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Dec 1, 2023 •
edited

Description

  • Updated ButtonLink to use text when size is auto. This also fixes the ButtonLink misalignment in TagUrl

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/1374
https://github.com/MetaMask/mobile-planning/issues/1258

Screenshots/Recordings

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-11-30.at.17.38.57.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen requested a review from a team as a code owner December 1, 2023 01:45
@brianacnguyen brianacnguyen self-assigned this Dec 1, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking Run Smoke E2E labels Dec 1, 2023
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Dec 1, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f102c24e-9282-4088-acaf-091c8ac58030
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

cortisiko
cortisiko approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good ✅

@brianacnguyen brianacnguyen merged commit eb2249d into main Dec 1, 2023
26 checks passed
@brianacnguyen brianacnguyen deleted the button-fix branch December 1, 2023 19:06
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 1, 2023
@metamaskbot metamaskbot added the release-7.14.0 Issue or pull request that will be included in release 7.14.0 label Dec 1, 2023
@cortisiko cortisiko restored the button-fix branch December 1, 2023 21:33
@cortisiko cortisiko deleted the button-fix branch December 1, 2023 21:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

@cortisiko cortisiko cortisiko approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-7.14.0 Issue or pull request that will be included in release 7.14.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brianacnguyen @georgewrmarshall @cortisiko @metamaskbot