Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Removing test selector strings within app code (5/7) #7989

Merged
merged 3 commits into from
Dec 4, 2023
Merged

test: Removing test selector strings within app code (5/7) #7989

merged 3 commits into from
Dec 4, 2023

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented Dec 1, 2023 •
edited

Description

We have instances where testIDs are not consistently stored in variables. This lack of uniformity can lead to redundant testID declarations throughout the codebase, resulting in code that is harder to maintain and prone to errors.

A more effective and best-practice approach is to store the testID value as a variable and then reference that variable when defining the testID property. By doing so, we centralize the testID values, reducing redundancy and making it easier to manage and maintain these identifiers throughout the codebase. This approach enhances code consistency and reduces the likelihood of introducing errors, ultimately contributing to a more robust and maintainable codebase.

Related issues

Fixes: #

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Smoke E2E test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c081b66c-78d1-4ec0-8bde-d0e83389855b
Regression E2E test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fc4ec84f-6c1a-4655-b67b-31d69c972ac0

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-client labels Dec 1, 2023
@cortisiko cortisiko requested a review from a team as a code owner December 1, 2023 23:05
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@metamaskbot metamaskbot added in-progress and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Dec 2, 2023
@cortisiko cortisiko added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed in-progress labels Dec 2, 2023
@cortisiko cortisiko linked an issue Dec 4, 2023 that may be closed by this pull request
[Batch 5/7] Remove all instances of strings in TestID property in the app code #7869
Closed
2 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a1bcac1b-a9af-40ac-b13d-276a9f498a6d
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

sethkfman
sethkfman approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko merged commit d884f7a into main Dec 4, 2023
36 checks passed
@cortisiko cortisiko deleted the update-testids/batch5 branch December 4, 2023 18:30
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 4, 2023
@metamaskbot metamaskbot added the release-7.14.0 Issue or pull request that will be included in release 7.14.0 label Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.14.0 Issue or pull request that will be included in release 7.14.0 team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Batch 5/7] Remove all instances of strings in TestID property in the app code
4 participants
@cortisiko @sethkfman @gauthierpetetin @metamaskbot