-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Send ETH using Deeplinks sets incorrect amount if is a thousand or higher #7998
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
8b2321a
to
733c0c0
Compare
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2c885202-b37f-4770-8bd3-d4d760dbc783 |
733c0c0
to
7a1e436
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7998 +/- ##
=======================================
Coverage 39.39% 39.40%
=======================================
Files 1220 1221 +1
Lines 29800 29804 +4
Branches 2831 2831
=======================================
+ Hits 11740 11743 +3
- Misses 17371 17372 +1
Partials 689 689 ☔ View full report in Codecov by Sentry. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Description
This PR simplifies the numeric value parsed from the deeplink url, removing decimals and adjusting based on the exponent.
Related issues
Fixes: #7769
Manual testing steps
Screenshots/Recordings
Before
send-deeplink-high.mp4
After
RPReplay_Final1701706536.MP4
Pre-merge author checklist
Pre-merge reviewer checklist